Bug 812156
| Summary: | slice2cpp generates bad code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Woehlke <mwoehlke.floss> | ||||
| Component: | ice | Assignee: | Haïkel Guémar <karlthered> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 17 | CC: | karlthered, mefoster | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-06-26 00:40:14 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Matthew Woehlke
2012-04-12 22:47:22 UTC
> Please either update ICE to a later version or backport the fix for 3.4.2.
Ice 3.4.2 is the latest release available and there is no public source repository, so neither of these options is possible.
Nonetheless I'll look forward patching slice2cpp.
Created attachment 577432 [details]
patch to fix generation of bad float constants
Thanks, and it is indeed unfortunate there is no public repository :-(.
If it helps, the patch I ended up applying locally is attached. I'm not convinced it is optimal, but it seems to do the trick for my project.
ice-3.4.2-12.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ice-3.4.2-12.fc17 @Matthew: thanks for sharing your patch, i made a little change since value is already a std::string so no need to convert it. Package ice-3.4.2-12.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ice-3.4.2-12.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-6076/ice-3.4.2-12.fc17 then log in and leave karma (feedback). Is it possible to push this fix to F16 as well? And it might be worth posting the patch on http://www.zeroc.com/forums/patches/ to make sure that it gets into subsequent versions of Ice. Oops, I see that the patch actually came from upstream :) Looks like -12 is missing the line in the .spec to apply the patch? There's a typo in the patch included in the current srpm -- there's an extra ")" at the end of one line. If you fix that, then it applies properly and fixes the issue. ice-3.4.2-13.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ice-3.4.2-13.fc17 ice-3.4.2-14.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ice-3.4.2-14.fc17 ice-3.4.2-15.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ice-3.4.2-15.fc17 ice-3.4.2-15.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |