Bug 812316

Summary:	Resource leaks in sed in error cases
Product:	Red Hat Enterprise Linux 6	Reporter:	Pavel Raiskup <praiskup>
Component:	sed	Assignee:	Vojtech Vitek <vvitek>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-tools-bugs
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.3	CC:	hripps, ovasik, pmuller
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 14:47:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Pavel Raiskup 2012-04-13 11:12:51 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Pavel Raiskup 2012-04-13 11:14:43 UTC

Hi, I'm very sorry for my unintentional press of 'Enter'.  Here is my report:
===============

Coverity difference scan of updates in rhel-6.3 revealed following resource
leak problem:

  Resource leak: sed-4.2.1/sed/utils.c: line 449 and 455

  There are not closed files 'infile' and 'outfile' properly.  I'm not sure how
  we should deal with memory leaks in error cases but it looks like this is
  unintentional.

  Note that this bug is added by RH patch sed-4.2.1-copy-option.patch

This bug is mentioned just as a warning and it depends on you whether it will
be fixed.  Feel free to move it to 6.4 or close it as a NOTABUG if you consider
it as unnecessary fix.

Quality engineering:
  This issue was found by static analysis tool and we can't provide any
  reproducer for these.  We will verify the fix once available.  Please check
  these tests as SanityOnly (just check that patches for the issues and nothing
  unexpected is added by the commit).  If you want to check the new package
  with Coverity yourself, feel free to use covscan tool
  (https://engineering.redhat.com/trac/CoverityScan/wiki/covscan).

Comment 10 errata-xmlrpc 2012-06-20 14:47:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0955.html