Bug 812526
| Summary: | Review Request: kolab-webadmin - Kolab Groupware Web Administration Panel | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | christoph.wickert, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-24 20:18:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Jeroen van Meeuwen
2012-04-14 11:41:23 UTC
Latest SRPM linked from this page: http://mirror.kolabsys.com/pub/redhat/kolab-3.0/el6/development/SRPMS/repoview/kolab-webadmin.html At the time of this writing: http://mirror.kolabsys.com/pub/redhat/kolab-3.0/el6/development/SRPMS/kolab-webadmin-2.4.2-1.el6.kolab_3.0.src.rpm SPEC URL: http://git.kolabsys.com/rpm/kolab-webadmin/plain/kolab-webadmin.spec?id=956d4643997dfb9daf32cfb28730bf81a98736ff SRPM URL: http://mirror.kolabsys.com/pub/redhat/kolab-3.0/el6/development/SRPMS/kolab-webadmin-3.0.3-6.el6.kolab_3.0.src.rpm reviewing... first off, 1. I see this package creating 3 users with static UIDs 412, 413, 414. Is there any justification for static uid over allowing the system to create these dynamically per examples mentioned on https://fedoraproject.org/wiki/Packaging:UsersAndGroups ? naming: ok
sources: NOT ok.
2. package MUST use verifiable sources.
srpm source md5sum:
19ff232d654d5497c9dabe4d7f159946 kolab-webadmin-3.0.3.tar.gz
Source0 URL md5sum:
9246c9844036141e21096361147eceac kolab-webadmin-3.0.3.tar.gz
license: ok
macros: ok
scriptlets: ok
but... I assume this is from legacy stuff to cleanup after older packaging?
if [ $1 -gt 1 ]; then
if [ ! -L "/usr/share/kolab-webadmin/hosted/js" ...
rm -rf /usr/share/kolab-webadmin/hosted/js >/dev/null 2>&1 || :
fi
...
fi
3. whatever it's purpose, you SHOULD document with a comment what it's for exactly. and maybe even consider removing or conditionalizing it for rhel only (ie, since none of these packages have been published for fedora, they are likely not needed).
otherwise, relatively simple web app here, please clarify points 1-3 for me.
ping? been about a month ... Marking as stalled review, feel free to reopen if you're ever interested in picking things up again. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |