Bug 812538

Summary: Review Request: herbstluftwm - Tiling window manager
Product: [Fedora] Fedora Reporter: Corey Richardson (:Octayn) <corey>
Component: Package ReviewAssignee: Jason Tibbitts <tibbs>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: corey, i, notting, package-review, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-08 15:40:57 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    

Description Corey Richardson (:Octayn) 2012-04-14 12:03:48 EDT
Spec URL: http://octayn.net/herbstluftwm.spec
SRPM URL: http://octayn.net/herbstluftwm-0.3-1.fc16.src.rpm

Description:
herbstluftwm is a manual tiling window manager for X, meaning frames are
manually split into sub-frames, where windows can be placed. All
configuration is done using IPC, so it is language-agnostic. The included
herbstclient program provides a simple interface. Custom layouts are
possible. Rules and hooks allow great flexibility. herbstluftwm can also
float windows.

This is my first package and I need a sponsor.
Comment 1 Corey Richardson (:Octayn) 2012-04-17 14:10:43 EDT
Thanks to some input from 'tipps' I've cleaned up the spec a bit. Removed an unnecessary line and made the paths in %files consistent. The new spec is live, and the new SRPM is at http://octayn.net/herbstluftwm-0.3-2.fc16.src.rpm
Comment 2 Jason Tibbitts 2012-04-19 09:56:41 EDT
Taking a look at this.
Comment 3 Jason Tibbitts 2012-04-20 17:26:07 EDT
OK, this builds fine (on rawhide); rpmlint has only one complaint:

  herbstluftwm.x86_64: W: non-conffile-in-etc
   /etc/bash_completion.d/herbstclient-completion
This is fine; those files shouldn't be there, but that's not your fault.

The project makefile is annoying; it hides the actual compiler call (so we can't verify the compiler flags it is using), does not provide a verbose mode and inserts control sequences which look more like line noise in the build logs.  I had to build with a quick patch to get that done properly:

diff -up ./rules.mk.orig ./rules.mk
--- ./rules.mk.orig     2012-04-20 16:05:30.840050949 -0500
+++ ./rules.mk  2012-04-20 16:05:44.030637343 -0500
@@ -4,18 +4,14 @@ all: $(TARGET)
 rb: clean all
 
 $(TARGET): $(OBJ)
-       $(call colorecho,LD,$(TARGET))
-       @$(LD) -o $@ $(LDFLAGS)  $(OBJ) $(LIBS)
+       $(LD) -o $@ $(LDFLAGS)  $(OBJ) $(LIBS)
 
 $(SRCDIR)/%.o: $(SRCDIR)/%.c $(HEADER)
-       $(call colorecho,CC,$<)
-       @$(CC) -c $(CFLAGS) -o $@ $<
+       $(CC) -c $(CFLAGS) -o $@ $<
 
 clean:
-       $(call colorecho,RM,$(TARGET))
-       @rm -f $(TARGET)
-       $(call colorecho,RM,$(OBJ))
-       @rm -f $(OBJ)
+       rm -f $(TARGET)
+       rm -f $(OBJ)
 
 info:
        @echo Some Info:

and the result is that indeed, the package isn't built with the proper Fedora compiler flags.  Unfortunately the makefile doesn't allow you to pass your own, so I used the following in %prep:

sed -i -e 's/^CFLAGS =.*/CFLAGS = %{optflags} -std=c99 -pedantic ${INCS} -D _XOPEN_SOURCE=600/' config.mk

Still seems to build after that but you'll need to do some testing.
Comment 4 Jason Tibbitts 2012-05-09 14:49:37 EDT
Any progress here?  Is there anything I can assist with?  If something about the above is unclear, please let me know and I'll try to help.
Comment 5 Jason Tibbitts 2012-06-08 15:40:57 EDT
Well, it's been another month with no response, so I'll go ahead and close this out.
Comment 6 Christopher Meng 2014-01-02 01:13:36 EST

*** This bug has been marked as a duplicate of bug 1001407 ***