|Summary:||insecure pid file permissions when using kobo.process.daemonize|
|Product:||[Fedora] Fedora||Reporter:||Dan Callaghan <dcallagh>|
|Component:||kobo||Assignee:||Daniel Mach <dmach>|
|Status:||CLOSED EOL||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2015-02-18 11:08:08 UTC||Type:||Bug|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
Description Dan Callaghan 2012-04-16 00:09:39 UTC
Description of problem: Daemon pid files written by kobo.process.daemonize have mode 0666, which is insecure (can be used to trick an initscript into killing any process, etc). Version-Release number of selected component (if applicable): kobo-0.3.6-1.el6.noarch How reproducible: always Steps to Reproduce: 1. Pass the daemon_pid_file argument to kobo.process.daemonize. 2. Check perms on the resulting file Actual results: Pid file has mode 0666. Expected results: Pid file should be 0644. Additional info: The function creates the pid file but never sets its mode. And right before that, it calls os.umask(0) so the file will always end up with mode 0666. Might be better to do something like os.open(pid_file, os.O_CREAT | os.O_EXCL, 0644) or better still, replace kobo's daemonizing code with the python-daemon package.
Comment 1 Daniel Mach 2012-07-10 15:28:19 UTC
Comment 2 Fedora End Of Life 2013-04-03 20:24:59 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19
Comment 3 Fedora End Of Life 2015-01-09 22:30:41 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 19. It is Fedora's policy to close all bug reports from releases that are no longer maintained. Approximately 4 (four) weeks from now this bug will be closed as EOL if it remains open with a Fedora 'version' of '19'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 19 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Comment 4 Fedora End Of Life 2015-02-18 11:08:08 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.