Bug 813306

Summary:	Review Request: accerciser - Interactive Python accessibility explorer for the GNOME desktop
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <kalevlember>
Component:	Package Review	Assignee:	Richard Shaw <hobbes1069>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hobbes1069, notting, package-review
Target Milestone:	---	Flags:	hobbes1069: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-18 12:18:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2012-04-17 12:58:18 UTC

Spec URL: http://kalev.fedorapeople.org/accerciser.spec
SRPM URL: http://kalev.fedorapeople.org/accerciser-3.4.1-1.fc17.src.rpm
Description:
Accerciser is an interactive Python accessibility explorer for the GNOME
desktop. It uses AT-SPI to inspect and control widgets, allowing you to check
if an application is providing correct information to assistive technologies
and automated test frameworks. Accerciser has a simple plugin framework which
you can use to create custom views of accessibility information.

Comment 1 Kalev Lember 2012-04-18 21:05:52 UTC

*** Bug 546738 has been marked as a duplicate of this bug. ***

Comment 2 Richard Shaw 2012-04-24 19:25:38 UTC

Initial spec review looks clean.

Comment 3 Richard Shaw 2012-04-24 20:48:16 UTC

Ok, I made sure it would build on rawhide and checked rpmlint:

$ rpmlint mockbuild/rawhide/accerciser/*.rpm
accerciser.noarch: E: explicit-lib-dependency libwnck3
accerciser.noarch: W: spelling-error %description -l en_US assistive -> assertive, passive, massive
accerciser.noarch: E: non-executable-script /usr/share/accerciser/plugins/ipython_view.py 0644L /usr/bin/python
accerciser.src: W: spelling-error %description -l en_US assistive -> assertive, passive, massive
2 packages and 0 specfiles checked; 2 errors, 2 warnings.

The only one I think you need to fix is the non-executable-script. I'm assuming that it isn't run directly but used as a module. In that case just remove the shebang either with sed or a patch and make sure upstream knows.

Comment 4 Richard Shaw 2012-04-25 17:01:04 UTC

+: OK
-: must be fixed
=: should be fixed (at your discretion)
?: Question or clairification needed
N: not applicable

MUST:
[+] rpmlint output: shown in comment.
[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license: BSD
[+] license field matches the actual license.
[+] license file is included in %doc: COPYING
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: md5sum matches (fba7edb13dd80ef63e6044b411a6a84f)
[+] package builds on at least one primary arch: Tested x86_64
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[N] ldconfig in %post and %postun
[+] no bundled copies of system libraries
[+] no relocatable packages
[+] package owns all directories that it creates
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[N] header files in -devel
[N] static libraries in -static
[N] .so in -devel
[N] -devel requires main package
[+] package contains no libtool archives
[+] package contains a desktop file, uses desktop-file-install/validate
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8

SHOULD:
[+] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock
[+] package builds on all supported arches: Tested x86_64
[?] package functions as described: Not tested
[+] sane scriptlets
[N] subpackages require the main package
[N] placement of pkgconfig files
[+] file dependencies versus package dependencies
[+] package contains man pages for binaries/scripts

Just make sure you take care of the non-executable-script problem.

*** APPROVED ***

Comment 5 Kalev Lember 2012-04-25 22:04:40 UTC

Thanks for the review, Richard!

Comment 6 Kalev Lember 2012-04-25 22:06:00 UTC

New Package SCM Request
=======================
Package Name: accerciser
Short Description: Interactive Python accessibility explorer for the GNOME desktop
Owners: kalev
Branches: f17
InitialCC:

Comment 7 Gwyn Ciesla 2012-04-26 12:08:01 UTC

Git done (by process-git-requests).