Bug 813386

Summary: [RFE] Run the upstream nspr test suite as part of the build
Product: Red Hat Enterprise Linux 5 Reporter: Elio Maldonado Batiz <emaldona>
Component: nsprAssignee: Elio Maldonado Batiz <emaldona>
Status: CLOSED CURRENTRELEASE QA Contact: Aleš Mareček <amarecek>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.9CC: amarecek
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nspr-4.9.5-2.el5 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-12 20:06:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Changes to spec file to run the tests in patch form kengert: review+

Description Elio Maldonado Batiz 2012-04-17 15:51:54 UTC 
Description of problem: Per the packaging guidelines we should run the test suite
as part of the build. This should be done in the spec file's %check section and the build should fail if any test fails. QE runs the test as  part of a shell script afterwards but it's best to do that and build time.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Build nspr with repmbuild --rebuild path-to-nspr-source-rpm
  
Actual results:
No tests are run

Expected results:
The test suite is run

Additional info:
We already do that for rhel 6.x, we should do likewise.
Comment 1 Elio Maldonado Batiz 2012-04-17 15:58:39 UTC 
Created attachment 578083 [details]
Changes to spec file to run the tests in patch form
Comment 2 Kai Engert (:kaie) (inactive account) 2012-04-18 00:18:29 UTC 
Comment on attachment 578083 [details]
Changes to spec file to run the tests in patch form

r=kaie
Comment 3 Elio Maldonado Batiz 2013-03-21 21:31:23 UTC 
Our own Packaging Guidelines require that on the spec file's %check section we run the test suite that upstream provides. It's time we comply with such good practice on RHEL-5.x as we already do on RHEL-6.x.
Comment 4 RHEL Program Management 2013-05-01 07:11:58 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unable to address this
request at this time.

Red Hat invites you to ask your support representative to
propose this request, if appropriate, in the next release of
Red Hat Enterprise Linux.
Comment 5 Elio Maldonado Batiz 2013-07-01 15:49:43 UTC 
Fixed with nspr-4.9.5-2.el5 as part of fixing Bug 737704.
Comment 6 Elio Maldonado Batiz 2014-02-12 20:06:53 UTC 
Funny, I have been asked to verify as as I was the bug reporter. I verified by examining http://download.devel.redhat.com/brewroot/packages/nspr/4.9.5/2.el5/data/logs/s390/build.log
As you can see the nspr usptream test suite was executed. Had any test failed the build would have failed.