Bug 813550

Summary:	[REGRESSION] be2iscsi: fix softirq errors when logging in and doing IO
Product:	Red Hat Enterprise Linux 6	Reporter:	Mike Christie <mchristi>
Component:	kernel	Assignee:	Mike Christie <mchristi>
Status:	CLOSED ERRATA	QA Contact:	Bruno Goncalves <bgoncalv>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.3	CC:	bgoncalv, kzhang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	kernel-2.6.32-269.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 08:47:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	738934

Description Mike Christie 2012-04-17 20:32:19 UTC

Description of problem:

In the upstream kernel the queuecommand callout is called with no locks held. In RHEL 6 libiscsi is still using the old style locking so the queuecomand function is called with the host lock held and irqs disabled.

So in RHEL 6 when beiscsi_alloc_pdu is called and and spin_unlock_bh is used it will cause errors.

There is not need to use the bh locking in beiscsi_alloc_pdu because libiscsi will always do the right thing.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 RHEL Program Management 2012-04-17 20:49:52 UTC

This request was evaluated by Red Hat Product Management for inclusion
in a Red Hat Enterprise Linux maintenance release. Product Management has 
requested further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed 
products. This request is not yet committed for inclusion in an Update release.

Comment 2 Mike Christie 2012-04-30 21:51:32 UTC

*** Bug 816190 has been marked as a duplicate of this bug. ***

Comment 3 Jarod Wilson 2012-05-02 16:21:22 UTC

Patch(es) available on kernel-2.6.32-269.el6

Comment 6 Bruno Goncalves 2012-05-04 07:33:45 UTC

Ran IO Stress test for 24 hours against NetApp target and no error has been found.

uname -r
2.6.32-269.el6.x86_64

rpm -q iscsi-initiator-utils
iscsi-initiator-utils-6.2.0.872-41.el6.x86_64

modinfo be2iscsi
filename:       /lib/modules/2.6.32-269.el6.x86_64/kernel/drivers/scsi/be2iscsi/be2iscsi.ko
license:        GPL
author:         Emulex Corporation
version:        4.2.162.0

Comment 8 errata-xmlrpc 2012-06-20 08:47:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0862.html