Bug 813574

Summary:	lab controller daemons should use python-daemon for daemonization
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	lab controller	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	0.8	CC:	bpeck, dcallagh, jdevries, mishin, rmancy, stl
Target Milestone:	0.11	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ImplementationQuality
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-17 04:34:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2012-04-17 22:45:51 UTC

For consistency with beakerd, we should use python-daemon (instead of kobo.process.daemonize) in the lab controller daemons as well.

See also bug 812687.

Comment 1 Dan Callaghan 2012-11-14 04:09:17 UTC

James wrote a patch for this: http://gerrit.beaker-project.org/#/c/1399/

I will just need to double-check that everything works nicely with gevent.

Comment 4 Raymond Mancy 2013-01-04 04:25:18 UTC

The main problem that I can find with this is that we daemonise before we try to login to the scheduler, and if the login fails we do not kill the process.

If time permits I think we should change this.

Comment 5 Dan Callaghan 2013-01-04 04:30:29 UTC

(In reply to comment #4)
> The main problem that I can find with this is that we daemonise before we
> try to login to the scheduler, and if the login fails we do not kill the
> process.
> 
> If time permits I think we should change this.

I've already tried to fix it, a long time ago:

http://gerrit.beaker-project.org/824

but it's not possible due to kobo bug 753006. I believe this patch for switching to python-daemon hasn't made the situation any worse than it was before.

Comment 6 Raymond Mancy 2013-01-04 04:34:44 UTC

Sorry I forgot about that old bug. And no this doesn't make it anyworse than before.

Comment 7 Dan Callaghan 2013-01-17 04:34:22 UTC

Beaker 0.11.0 has been released.