Bug 813865

Summary:	support raw ipv6 addresses in URIs
Product:	Red Hat Enterprise Linux 6	Reporter:	Daniel Berrangé <berrange>
Component:	spice-gtk	Assignee:	Daniel Berrangé <berrange>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.3	CC:	acathrow, cfergeau, dallan, dblechte, desktop-qa-list, djasa, dyasny, gkong, jwu, mkrcmari, mzhan, rwu, yupzhang, zpeng
Target Milestone:	rc	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spice-gtk-0.14-1.el6	Doc Type:	Bug Fix
Doc Text:	Cause: Bugs in remote-viewer URI parsing when the URI contains an IPv6 address Consequence: remote-viewer cannot be started from the command line with an IPv6 URI Fix: Fix parsing of URIs containing IPv6 addresses Result: It's possible to connect to IPv6 addresses when starting remote-viewer from the command line.	Story Points:	---
Clone Of:	813375
Clones:	873263 (view as bug list)		Environment:
Last Closed:	2013-02-21 08:47:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	813375
Bug Blocks:	840699

Description Daniel Berrangé 2012-04-18 15:46:07 UTC

+++ This bug was initially created as a clone of Bug #813375 +++

Description of problem:
support ipv6 addresses on CLI. IPv6 passed via controller works.

Version-Release number of selected component (if applicable):
virt-viewer-0.5.2-4

How reproducible:
always

Steps to Reproduce:
try to connect to qemu over ipv6:
1. remote-viewer spice://ipv6_addr/?port=PORT
2. remote-viewer spice://[ipv6_addr]/?port=PORT
3.
  
Actual results:
none of above works

Expected results:
some of above works

Additional info:
when address is passed via controller, remote-viewer works

--- Additional comment from berrange on 2012-04-18 16:45:35 BST ---

The RFC compliant syntax would be the second example you give

>  remote-viewer spice://[ipv6_addr]/?port=PORT

I have confirmed that this is indeed broken for both SPICE and VNC. The VNC support can be fixed in virt-viewer itself. The SPICE fix needs to be done in SPICE-GTK

Comment 1 Daniel Berrangé 2012-04-18 15:46:40 UTC

Proof of concept upstream patch:

http://lists.freedesktop.org/archives/spice-devel/2012-April/008769.html

Comment 4 Daniel Berrangé 2012-04-19 14:58:17 UTC

Alternative patch now posted

http://lists.freedesktop.org/archives/spice-devel/2012-April/008808.html

Comment 5 Andrew Cathrow 2012-04-23 14:25:13 UTC

What's the driver for this being a blocker for 6.3?

Comment 6 Daniel Berrangé 2012-04-23 14:29:10 UTC

AFAIK, IPv6 support was a requirement of any RHEL6 application, in this case we need spice-gtk to support it for virt-viewer, so that it can connect to an IPv6 enabled KVM host

Comment 7 Daniel Berrangé 2012-04-23 16:54:29 UTC

New (hopefully final) version of upstream patch

http://lists.freedesktop.org/archives/spice-devel/2012-April/008833.html

Comment 8 Daniel Berrangé 2012-04-24 09:54:01 UTC

Committed upstream in

commit 50add15ef69cde34346e11b5c91e1257cecb2696
Author: Daniel P. Berrange <berrange>
Date:   Thu Apr 19 11:12:09 2012 +0100

    Fix multiple problems with URI parsing

Comment 11 David Blechter 2012-05-22 15:15:42 UTC

moving to 6.4. Deadline is less than 24 hours from now. The patches were not approved upstream.

Comment 12 David Jaša 2012-05-31 16:28:33 UTC

please take bug #827115 into account when looking at the patches.

Comment 19 errata-xmlrpc 2013-02-21 08:47:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0343.html