Bug 813873
| Summary: | New logging action with detailed debug and trace output | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise SOA Platform 5 | Reporter: | Len DiMaggio <ldimaggi> |
| Component: | JBossESB | Assignee: | tcunning |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Pechanec <jpechane> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.3.0 GA | CC: | dlesage, dpalmer, jpechane, myarboro, soa-p-jira, tcunning |
| Target Milestone: | CR1 | ||
| Target Release: | 5.3.0 GA | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
There is now a new logging action with
detailed debug and trace output that can be added to the action chain.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-15 17:26:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Len DiMaggio
2012-04-18 15:59:50 UTC
Functionality is present but with a bug in constructor currCategoryName = configTree.getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG); currActionName = configTree.getAttribute(ListenerTagNames.ACTION_ELEMENT_TAG); There is no category attribute on action element
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
There is now a new logging action with
detailed debug and trace output that can be added to the action chain.
The code has been changed to:
public ServiceLoggerAction(ConfigTree configTree) {
myLogger = Logger.getLogger(configTree.getParent().getAttribute(
ListenerTagNames.SERVICE_CATEGORY_NAME_TAG)
+ "."
+ configTree.getParent().getAttribute(ListenerTagNames.SERVICE_NAME_TAG));
currActionName = configTree.getAttribute(ListenerTagNames.ACTION_ELEMENT_TAG);
printlnMessage = configTree.getAttribute(PRE_MESSAGE, currActionName);
payloadProxy = new MessagePayloadProxy(configTree);
}
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1,2 +1 @@
-There is now a new logging action with
+There is now a new logging action with
detailed debug and trace output that can be added to the action chain.-detailed debug and trace output that can be added to the action chain.
myLogger = Logger.getLogger(configTree.getParent().getAttribute(
ListenerTagNames.SERVICE_CATEGORY_NAME_TAG) + "."
+ configTree.getParent().getAttribute(ListenerTagNames.SERVICE_NAME_TAG));
Line
currCategoryName = configTree.getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG);
should be
currCategoryName = configTree.getAttribute(configTree.getParent().getAttribute(ListenerTagNames.SERVICE_CATEGORY_NAME_TAG));
One more question - why do you concat category and action name? Would not it make more sense to concat service and action name? Or category, service and action?
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1 +1,2 @@
-There is now a new logging action with
detailed debug and trace output that can be added to the action chain.+There is now a new logging action with
+detailed debug and trace output that can be added to the action chain.
public static final String LOG_PAYLOAD_LOCATION_TAG = "get-payload-location"; this line is wrong. The name of the property conflicts with public static final String GET_PAYLOAD_LOCATION = "get-payload-location"; as defined in MessagePayloadProxy The property as define in ServiceLoggerAction expects to be true/false and is flag to enable logging of the payload location. Unfortunately it overwrites the location that is expected by MessagePayloadProxy
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1,2 +1 @@
-There is now a new logging action with
+There is now a new logging action with
detailed debug and trace output that can be added to the action chain.-detailed debug and trace output that can be added to the action chain.
public static final String LOG_PAYLOAD_LOCATION_TAG = "get-payload-location"; this line is wrong. The name of the property conflicts with public static final String GET_PAYLOAD_LOCATION = "get-payload-location"; as defined in MessagePayloadProxy The property as define in ServiceLoggerAction expects to be true/false and is flag to enable logging of the payload location. Unfortunately it overwrites the location that is expected by MessagePayloadProxy Fixed the issue Jiri talks about above, and also changed the log4j category to <JBOSSESB-COMMON-STRING>.<DEPLOYMENT> .<SERVICE-CATEGORY>.<SERVICE-NAME> so that we can filter by deployment and provide a case where all ServiceLoggerActions are configured.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
Diffed Contents:
@@ -1 +1,2 @@
-There is now a new logging action with
detailed debug and trace output that can be added to the action chain.+There is now a new logging action with
+detailed debug and trace output that can be added to the action chain.
Please verify this issue on 5.3.0 CR1. Verified in CR1 |