Bug 813944
Summary: | missing TCP_CONGESTION | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Curtis Doty <curtis> | ||||
Component: | ttcp | Assignee: | Michal Sekletar <msekleta> | ||||
Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 23 | CC: | jsynacek, msekleta | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-12-20 12:13:03 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Curtis Doty
2012-04-18 20:14:57 UTC
We can add new command line option. I think -C switch is unused so far,thus we can use it for this purpose. This RFE is easy to implement, however here is one concern we should take into the count. There is at least 5 or 6 congestion control algorithms I'm aware of and there is a mechanism in kernel to register and use new or customized algorithm, but only few of them are usable out-of-box, in my case only 2 (cubic, reno). I will implement this, without any restrictions on -C option value and I will assume that user is aware about choices he has available. We will try to set selected algorithm in everytime. If he picks algorithm which is not available on target system, setsockopt() will return failure and we will exit program with error code. I will add comment to man page how to put in use more algorithms by loading appropriate kernel modules. By default, only cubic and reno modules are loaded and allowed. $ cat /proc/sys/net/ipv4/tcp_available_congestion_control cubic reno $ cat /proc/sys/net/ipv4/tcp_allowed_congestion_control cubic reno However, there are a bunch more available in the kernel. For example. $ sudo modprobe tcp_htcp $ cat /proc/sys/net/ipv4/tcp_available_congestion_control cubic reno htcp Of course, it still can't be used until you authorize it like this. $ sudo sh -c 'echo cubic reno htcp >>/proc/sys/net/ipv4/tcp_allowed_congestion_control' $ cat /proc/sys/net/ipv4/tcp_allowed_congestion_control cubic reno htcp Tada! Now--I think--you should be able to setsockopt() with TCP_CONGESTION. Not sure if there are different error conditions for "algorithm not loaded or unknown" and "algorithm not allowed." Created attachment 588020 [details]
Added implementation of -C command line option
This message is a reminder that Fedora 17 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 17. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '17'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 17's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 17 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 17's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |