Bug 814024

Summary:	rhc-idler does NOT work
Product:	OKD	Reporter:	Johnny Liu <jialiu>
Component:	Containers	Assignee:	Jhon Honce <jhonce>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.x	CC:	bmeng, mpatel
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-27 20:46:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Johnny Liu 2012-04-19 03:32:24 UTC

Description of problem:
This bug is introduced by 10797174f2686396ea75c8bc687ee21ac8112c04.

[root@ip-10-118-203-101 stickshift]# rhc-idler -u 7ae27dfb799c4c83b688d60886d6a1d1
[root@ip-10-118-203-101 stickshift]# rhc-idler -l
[root@ip-10-118-203-101 stickshift]# sh -x rhc-idler -u 7ae27dfb799c4c83b688d60886d6a1d1
+ TRUE=0
+ FALSE=1
+ getopts u:dl OPTION
+ case $OPTION in
+ uuid=7ae27dfb799c4c83b688d60886d6a1d1
+ getopts u:dl OPTION
+ '[' '!' -z '' ']'
+ '[' -z 7ae27dfb799c4c83b688d60886d6a1d1 ']'
+ '[' -d /var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1 ']'
+ source /var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/.env/OPENSHIFT_GEAR_DIR
++ export OPENSHIFT_GEAR_DIR=/var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/
++ OPENSHIFT_GEAR_DIR=/var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/
+ source /var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/.env/OPENSHIFT_RUNTIME_DIR
++ export OPENSHIFT_RUNTIME_DIR=/var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/runtime/
++ OPENSHIFT_RUNTIME_DIR=/var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/runtime/
++ is_idled 7ae27dfb799c4c83b688d60886d6a1d1
++ appid=7ae27dfb799c4c83b688d60886d6a1d1
++ grep -q ' #ProxyPass' /etc/httpd/conf.d/stickshift/7ae27dfb799c4c83b688d60886d6a1d1_jialiu_redmine.conf
++ return 1
++ is_stopped 7ae27dfb799c4c83b688d60886d6a1d1
+++ get_state 7ae27dfb799c4c83b688d60886d6a1d1
+++ source /var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/.env/OPENSHIFT_RUNTIME_DIR
++++ export OPENSHIFT_RUNTIME_DIR=/var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/runtime/
++++ OPENSHIFT_RUNTIME_DIR=/var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/runtime/
+++ cat /var/lib/stickshift/7ae27dfb799c4c83b688d60886d6a1d1/redmine/runtime//.state
++ _test=started
+++ test stopped = started
++ return
+ '[' -o ']'
+ exit 0

After I use
if `is_idled "$uuid"` || `is_stopped "$uuid"` ; then
to replace
if [ `is_idled "$uuid"` -o `is_stopped "$uuid"` ]; then
it works fine.

Version-Release number of selected component (if applicable):
devenv_1730

How reproducible:
Always

Steps to Reproduce:
1. 
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jhon Honce 2012-04-19 16:16:19 UTC

Suggested changes made in commit 45e70e22e42b479f8607809adb5edcfa75fa8595

Comment 2 Meng Bo 2012-04-20 02:33:57 UTC

verified on devenv_1732, issue has been fixed.