Bug 814071
Summary: | Review Request: rubygem-aruba - CLI Steps for Cucumber, hand-crafted for you in Aruba | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bohuslav "Slavek" Kabrda <bkabrda> |
Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review, tdawson, vondruch |
Target Milestone: | --- | Flags: | vondruch:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | rubygem-aruba-0.4.11-2.fc17 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-05-02 04:44:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Bohuslav "Slavek" Kabrda
2012-04-19 07:31:48 UTC
I'll take it for a review ride. Seems that the gem dependencies are not fulfilled: Error: Package: rubygem-aruba-0.4.11-1.fc18.noarch (/rubygem-aruba-0.4.11-1.fc18.noarch) Requires: rubygem(ffi) >= 1.0.11 Installed: rubygem-ffi-1.0.9-4.fc17.i686 (@fedora) rubygem(ffi) = 1.0.9 However, I am wondering why there is the FFI dependency at all, since there doesn't seems to be any code which uses it Otherwise, the package looks good, I almost approved it ;) I have asked upstream about the ffi dependency [1]. Basically, they only wanted the ffi version 1.0.10 not to be drawn in by childprocess. So I'll patch the gemspec and specfile properly. [1] https://github.com/cucumber/aruba/issues/114 Ok, so I have removed the ffi dependency, because it's not dependency of childprocess, not aruba itself. I added a "[Build]Conflicts: rubygem(ffi) = 1.0.10" so that the package won't install with this broken version of ffi. SPEC: http://bkabrda.fedorapeople.org/pkgs/aruba/rubygem-aruba.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/aruba/rubygem-aruba-0.4.11-2.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4005183 Thank you. While I don't like the "conflicts", I have no better solution on the other hand. So I APPROVE the package. Thanks for your review! New Package SCM Request ======================= Package Name: rubygem-aruba Short Description: CLI Steps for Cucumber, hand-crafted for you in Aruba Owners: bkabrda Branches: f17 InitialCC: Git done (by process-git-requests). rubygem-aruba-0.4.11-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-aruba-0.4.11-2.fc17 rubygem-aruba-0.4.11-2.fc17 has been pushed to the Fedora 17 testing repository. rubygem-aruba-0.4.11-2.fc17 has been pushed to the Fedora 17 stable repository. Package Change Request ====================== Package Name: rubygem-aruba New Branches: epel7 Owners: tdawson Git done (by process-git-requests). |