Bug 814156

Summary: help_msg should use argv[0] except of PACKAGE
Product: [Fedora] Fedora Reporter: Lubos Kocman <lkocman>
Component: virt-viewerAssignee: Daniel Berrange <berrange>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 17CC: berrange, cfergeau, crobinso, dblechte, dyasny
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 814150 Environment:
Last Closed: 2012-12-14 16:17:13 EST Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Lubos Kocman 2012-04-19 06:16:16 EDT
+++ This bug was initially created as a clone of Bug #814150 +++

Description of problem:

remote-viewer and virt-viewer are both using following constant for the usage print

const char *help_msg = N_("Run '" PACKAGE " --help' to see a full list of available command line options");

Which leads to:

$ remote-viewer --hfsdafd
Unknown option --hfsdafd
Run 'virt-viewer --help' to see a full list of available command line options

$ virt-viewer --hfsdafd
Unknown option --hfsdafd
Run 'virt-viewer --help' to see a full list of available command line options

printing virt-viewer in both cases



Version-Release number of selected component (if applicable):

(this could be fixed in both fedora and rhel)

How reproducible:


Steps to Reproduce:
1.remote-viewer --hfsdafd

  
Actual results:

Unknown option --hfsdafd
Run 'virt-viewer --help' to see a full list of available command line options


Expected results:

Unknown option --hfsdafd
Run 'remote-viewer --help' to see a full list of available command line options


Additional info:

This is also worth a look

[lkocman@dhcp-29-219 kvm]$ remote-viewer sdfdsaf
Segmentation fault
Comment 1 Cole Robinson 2012-12-14 16:17:13 EST
The latter issue is fixed in F17 already, but the argv[0] bit persists. However both are fixed in F18, and since it's a minor bit, just closing as NEXTRELEASE