Bug 814514
Summary: | Rules from Guided Editor is disabled when used "From Collect" CE | ||||||
---|---|---|---|---|---|---|---|
Product: | [JBoss] JBoss Enterprise BRMS Platform 5 | Reporter: | Alessandro Lazarotti <alazarot> | ||||
Component: | BRM (Guvnor) | Assignee: | manstis | ||||
Status: | VERIFIED --- | QA Contact: | |||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | BRMS 5.3.0.GA | CC: | rzhang | ||||
Target Milestone: | ER8 | ||||||
Target Release: | BRMS 5.3.0.GA | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: |
When using the BRMS guided editor to create rules with 'From collect' the rule would be disabled, this was because it was necessary to import java.uti.List. This has been resolved and the import is now automatically added allowing the user to create and modify the rules.
|
Story Points: | --- | ||||
Clone Of: | Environment: | ||||||
Last Closed: | Type: | Bug | |||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Alessandro Lazarotti
2012-04-20 03:42:26 UTC
Created attachment 578853 [details]
Screenshot
Michael Anstis <michael.anstis> made a comment on jira GUVNOR-1871 Have you imported java.util.List into the package definition? Michael Anstis <michael.anstis> made a comment on jira GUVNOR-1871 Alexandre, feel free to assign this (and the Bugzilla) to me - unless this is something you 1) want to look at, or 2) is something that needs fixing today (20th) for BRMS 5.3? Alexandre Porcelli <alexandre.porcelli> made a comment on jira GUVNOR-1871 Don't worry Mike - I've been supporting Alessandro to reproduce it - so I can work on that with no problem (and i can learn something outside what i've been working). Michael Anstis <michael.anstis> made a comment on jira GUVNOR-1871 Ok, no problem. It is probably the missing import...;) Alessandro Lazarotti <alazarot> made a comment on jira GUVNOR-1871 Hi mantis, Actually add an import to java.uti.List (or another collection) works, I've just re-tested. However it is a workaround, since this should not be necessary. The generated code from the Guided Editor is: something like: 1. | rule "rule1" 2. | dialect "mvel" 3. | when 4. | java.util.List( ) from collect ( ) 5. | then 6. | end The collection uses a full qualified name, so should not be necessary to add an import statement As a reasonable workaround can be used (look technical notes), GSS is prioritizing this ticket as "medium" level. Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Workaround: Declaring the collection in imported types: 1) in the package view, click on Edit tab 2) in "Configuration:imported types", click on the plus icon 3) put the full qualified name of the collection in the filed "(advanced) class name" and ok 4) File > Save changes Michael Anstis <michael.anstis> made a comment on jira GUVNOR-1871 It might be best to ensure java.util.List is added as an import when a rule defined with the Guided Rule Editor has a collect (or accumulate). Even better to check, if the import is removed and any rule needs it to ti e a warning (this could equally apply if any import is removed that is needed). Note: the Guided Decision Table editor also allows columns to be defined that use "from collect" etc so an import will be needed for these too. Rule Templates also have the same requirement but use the same editor as the Guided Rule Editor so should not need special consideration. Michael Anstis <michael.anstis> made a comment on jira GUVNOR-1871 This is also related: https://bugzilla.redhat.com/show_bug.cgi?id=760502 Alexandre Porcelli <alexandre.porcelli> made a comment on jira GUVNOR-1871 Bug fixed on master - https://github.com/droolsjbpm/guvnor/commit/8cbc88e9326690e62e175e91ca5c770d514aaab7 Alexandre Porcelli <alexandre.porcelli> updated the status of jira GUVNOR-1871 to Resolved bug fixed on master and 5.4.x branches. Yes, as Alexandre pointed out, it is not in 5.3.x branch, so it wounldn't be picked by BRMS 5.3. As it 's not in block+ and 5.3.0+ flag, assign it to Anne to decide where it should go. cc Lukas as QE expect it by set qa_ack+. Requesting blocker, otherwise it's not going to land in 5.3 anyway. Assign back to Alessandro. Please back port this to 5.3.x branch. done, back ported to 5.3.x branch The fixed for this issue should be included in ER7. Please do verification on it. Please, can you tell me what should be exected behaviour of this issue? There is no warnings that I need import java.util.Collection into package. In Business Rule - Guided Editor: I can observe same behaviour as was described in comment #1 and is displayed on attached image. In Decision Table - Web Guided Editor: They put import automaticaly. You are right Sona, I've tested using ER7 and the issue is still there. (In reply to comment #21) > You are right Sona, > I've tested using ER7 and the issue is still there. Re-opening. Just double checked on 5.3.x branch and it does work. Probably my commit is missing on product branch, here is the commit sha1 that fixes this issue: d13fa24683ef0be89fa40f20392892c8c78c59d6 Yes, it's my mistake. The ER7's upstream code cutting date is May 10, and ER7's announce date is May 14. So this issue happens to be committed in May 11 which I didn't notice that. Any way I have comfirmed this has been picked up by ER8. I updated the status to ON_QA and Milestone to ER8 Verified for ER8. I do not need import any more and "From Collect" section is enable to modify. Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,6 +1 @@ -Workaround: +When using the BRMS guided editor to create rules with 'From collect' the rule would be disabled, this was because it was necessary to import java.uti.List. This has been resolved and the import is now automatically added allowing the user to create the rules.- Declaring the collection in imported types: - 1) in the package view, click on Edit tab - 2) in "Configuration:imported types", click on the plus icon - 3) put the full qualified name of the collection in the filed "(advanced) class name" and ok - 4) File > Save changes Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1 @@ -When using the BRMS guided editor to create rules with 'From collect' the rule would be disabled, this was because it was necessary to import java.uti.List. This has been resolved and the import is now automatically added allowing the user to create the rules.+When using the BRMS guided editor to create rules with 'From collect' the rule would be disabled, this was because it was necessary to import java.uti.List. This has been resolved and the import is now automatically added allowing the user to create and modify the rules. |