Bug 814772

Summary: Repos with i18n character in id and has a sync plan, the task doesn't get deleted when the repo is deleted
Product: [Retired] Pulp Reporter: Preethi Thomas <pthomas>
Component: z_otherAssignee: Sayli Karmarkar <skarmark>
Status: CLOSED CURRENTRELEASE QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.1.0CC: cperry
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-25 14:14:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Preethi Thomas 2012-04-20 15:47:16 UTC
Description of problem:
Repo sync schedule task doesn't get deleted when a repo is deleted and has an i18n character and has a scheduled sync

Version-Release number of selected component (if applicable):
[root@pulp-v1-1-server ~]# rpm -q pulp
pulp-1.1.3-1.fc16.noarch


How reproducible:


Steps to Reproduce:
1.create a repo
2.create a sync schedule for the repo
3.let the sync run once
4.delete the repo
5. check the task list
6. See pulp.log
  
Actual results:
deleted repos are still scheduled to sync

Expected results:


Additional info:

[root@pulp-v1-1-server ~]# pulp-admin task list
Task: 2f8bee9c-8afe-11e1-8599-525400fbc951
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: katello-Brasília
    State: finished
    Start time: 2012-04-20T11:33:32-04:00
    Finish time: 2012-04-20T11:33:32-04:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None

Task: ea6bf121-8afa-11e1-976a-525400fbc951
    Job: None
    Scheduler: interval
    Call: _sync
    Arguments: katello-Brasília
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-20T15:35:00Z
    Result: None
    Exception: None
    Traceback: None

Task: 5863a2e6-8a48-11e1-8fee-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_history
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-21T05:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: 58647778-8a48-11e1-8ff4-525400fbc951
    Job: None
    Scheduler: interval
    Call: _sync
    Arguments: Brasília
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-20T15:35:00Z
    Result: None
    Exception: None
    Traceback: None


[root@pulp-v1-1-server ~]# pulp-admin repo list
+------------------------------------------+
       List of Available Repositories
+------------------------------------------+

Id                 	testrepo                 
Name               	testrepo                 
Repo URL           	https://pulp-v1-1-server.usersys.redhat.com/pulp/repos/testrepo/
Feed URL           	None                     
Feed Type          	None                     
Content Type       	yum                      
Feed Certs         	CA:No   Cert:No
Consumer Certs     	CA:No   Cert:No
Architecture       	noarch                   
Sync Schedule      	None                     
Packages           	1                        
Files              	0                        
Distributions      	None                     
Publish            	True                     
Clones             	[]                       
Groups             	None                     
Filters            	[]                       
Notes              	{}                       
Preserve Metadata  	False                    
Checksum Type      	sha256                   


Id                 	test                     
Name               	test                     
Repo URL           	https://pulp-v1-1-server.usersys.redhat.com/pulp/repos/brewroot/repos/se-rhel-6-build/latest/x86_64/
Feed URL           	http://download.devel.redhat.com/brewroot/repos/se-rhel-6-build/latest/x86_64/
Feed Type          	remote                   
Content Type       	yum                      
Feed Certs         	CA:No   Cert:No
Consumer Certs     	CA:No   Cert:No
Architecture       	noarch                   
Sync Schedule      	None                     
Packages           	0                        
Files              	0                        
Distributions      	None                     
Publish            	True                     
Clones             	[]                       
Groups             	None                     
Filters            	[]                       
Notes              	{}                       
Preserve Metadata  	False                    
Checksum Type      	sha256                   


Id                 	local-1                  
Name               	local-1                  
Repo URL           	https://pulp-v1-1-server.usersys.redhat.com/pulp/repos/local-1/
Feed URL           	file:///root/local-repo/ 
Feed Type          	local                    
Content Type       	yum                      
Feed Certs         	CA:No   Cert:No
Consumer Certs     	CA:No   Cert:No
Architecture       	noarch                   
Sync Schedule      	None                     
Packages           	0                        
Files              	0                        
Distributions      	None                     
Publish            	True                     
Clones             	[]                       
Groups             	None                     
Filters            	[]                       
Notes              	{}                       
Preserve Metadata  	False                    
Checksum Type      	sha256                   


Id                 	f16-new                  
Name               	f16-new                  
Repo URL           	https://pulp-v1-1-server.usersys.redhat.com/pulp/repos/f16-new/
Feed URL           	http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/
Feed Type          	remote                   
Content Type       	yum                      
Feed Certs         	CA:No   Cert:No
Consumer Certs     	CA:No   Cert:No
Architecture       	noarch                   
Sync Schedule      	None                     
Packages           	3107                     
Files              	0                        
Distributions      	ks-Fedora-Fedora-16-x86_64
Publish            	True                     
Clones             	[]                       
Groups             	None                     
Filters            	[]                       
Notes              	{}                       
Preserve Metadata  	False                    
Checksum Type      	sha256                   


Id                 	f16                      
Name               	f16                      
Repo URL           	https://pulp-v1-1-server.usersys.redhat.com/pulp/repos/released/F-16/GOLD/Fedora/x86_64/os/
Feed URL           	http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/
Feed Type          	remote                   
Content Type       	yum                      
Feed Certs         	CA:No   Cert:No
Consumer Certs     	CA:No   Cert:No
Architecture       	noarch                   
Sync Schedule      	None                     
Packages           	3107                     
Files              	0                        
Distributions      	ks-Fedora-Fedora-16-x86_64
Publish            	True                     
Clones             	[]                       
Groups             	None                     
Filters            	[]                       
Notes              	{}                       
Preserve Metadata  	False                    
Checksum Type      	sha256                   


[root@pulp-v1-1-server ~]# 


pulp.log

2012-04-20 11:45:02,064 24914:140087304107776: pulp.server.api.repo:ERROR: repo:2305 no repo exists for [katello-Brasília]
2012-04-20 11:45:02,065 24914:140087304107776: pulp.server.api.repo_sync:ERROR: repo_sync:261 We saw sync was in progress for [katello-Brasília]
2012-04-20 11:45:02,066 24914:140087304107776: pulp.server.tasking.task:ERROR: task:472 Task failed: Task ea6bf121-8afa-11e1-976a-525400fbc951: _sync(katello-Brasília, synchronizer=<pulp.server.api.synchronizers.YumSynchronizer object at 0x7f68b5bf0210>, skip={}, progress_callback=<bound method RepoSyncTask.progress_callback of <pulp.server.api.repo_sync_task.RepoSyncTask object at 0x7f68b5bf0a10>>)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/pulp/server/tasking/task.py", line 418, in run
    result = self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 262, in _sync
    raise ConflictingOperationException(_('Sync for repo [%s] already in progress') % repo_id)
ConflictingOperationException: Sync for repo [katello-Brasília] already in progress

Comment 1 Sayli Karmarkar 2012-04-25 09:04:57 UTC
Looks like when deleting scheduled sync task during repo deletion, we were not encoding i18n ids properly. Added following fix - 

commit 0057adcbff5d9ada5499e8496ffb4cbed8783f8b
Author: Sayli Karmarkar <skarmark>
Date:   Wed Apr 25 02:03:28 2012 -0700

    814772 - adding i18n repo id encoding when searching through scheduled tasks

Comment 2 Sayli Karmarkar 2012-04-25 09:25:51 UTC
$ pulp-admin repo delete --id Brasília
Repository [ Brasília ] being deleted

$ pulp-admin repo list
No repositories available to list

$ pulp-admin task list
Task: 3e7e2c0f-8eb8-11e1-89f4-1c659d8e492e
    Job: None
    Scheduler: interval
    Call: cull_audited_events
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-25T20:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: 3e7e44e6-8eb8-11e1-89f5-1c659d8e492e
    Job: None
    Scheduler: interval
    Call: cull_history
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-26T08:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: 888ec121-8eb8-11e1-af58-1c659d8e492e
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: Brasília
    State: finished
    Start time: 2012-04-25T02:25:01-07:00
    Finish time: 2012-04-25T02:25:01-07:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None

Comment 3 Jeff Ortel 2012-04-26 19:59:59 UTC
build: 1.1.5

Comment 4 Preethi Thomas 2012-04-27 14:36:52 UTC
[root@pulp-v1-1-server ~]# pulp-admin  repo create --id Brasília --feed http://repos.fedorapeople.org/repos/pulp/pulp/v1/testing/fedora-16/x86_64/error:  operation failed: No valid authorization credentials found, please see: pulp-admin --help
[root@pulp-v1-1-server ~]# pulp-admin -u admin -p admin  repo create --id Brasília --feed http://repos.fedorapeople.org/repos/pulp/pulp/v1/testing/fedora-16/x86_64/
Successfully created repository [ Brasília ]

[root@pulp-v1-1-server ~]# pulp-admin -u admin -p admin repo sync --id=Brasília --interval=PT5M --start=2012-02-07T12:40:00-01:00:
Sync schedule for repo [ Brasília ] changed to [ 2012-02-07T12:40:00-01:00/PT5M ]
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# pulp-admin auth login -u admin -p admin
User credentials successfully stored at [/root/.pulp/user-cert.pem]

[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# 
[root@pulp-v1-1-server ~]# pulp-admin task list
Task: f033442e-9071-11e1-b9ce-525400fbc951
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: test-new
    State: finished
    Start time: 2012-04-27T10:04:43-04:00
    Finish time: 2012-04-27T10:04:43-04:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None

Task: b2ca5378-9073-11e1-82ca-525400fbc951
    Job: None
    Scheduler: interval
    Call: _sync
    Arguments: Brasília
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-27T14:35:00Z
    Result: None
    Exception: None
    Traceback: None

Task: 918da45c-9071-11e1-8d86-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_history
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-28T05:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: 918d8211-9071-11e1-8d85-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_audited_events
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-27T17:00:00Z
    Result: None
    Exception: None
    Traceback: None


[root@pulp-v1-1-server ~]# pulp-admin repo delete --id Brasília
Repository [ Brasília ] being deleted

[root@pulp-v1-1-server ~]# pulp-admin task list
Task: 918d8211-9071-11e1-8d85-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_audited_events
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-27T17:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: e1b4edba-9075-11e1-91b4-525400fbc951
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: Brasília
    State: finished
    Start time: 2012-04-27T10:32:57-04:00
    Finish time: 2012-04-27T10:32:57-04:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None

Task: 918da45c-9071-11e1-8d86-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_history
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-28T05:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: f033442e-9071-11e1-b9ce-525400fbc951
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: test-new
    State: finished
    Start time: 2012-04-27T10:04:43-04:00
    Finish time: 2012-04-27T10:04:43-04:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None


[root@pulp-v1-1-server ~]# pulp-admin task list
Task: 918d8211-9071-11e1-8d85-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_audited_events
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-27T17:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: e1b4edba-9075-11e1-91b4-525400fbc951
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: Brasília
    State: finished
    Start time: 2012-04-27T10:32:57-04:00
    Finish time: 2012-04-27T10:32:57-04:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None

Task: 918da45c-9071-11e1-8d86-525400fbc951
    Job: None
    Scheduler: interval
    Call: cull_history
    Arguments: 
    State: waiting
    Start time: None
    Finish time: None
    Scheduled time: 2012-04-28T05:00:00Z
    Result: None
    Exception: None
    Traceback: None

Task: f033442e-9071-11e1-b9ce-525400fbc951
    Job: None
    Scheduler: immediate
    Call: RepoApi.delete
    Arguments: test-new
    State: finished
    Start time: 2012-04-27T10:04:43-04:00
    Finish time: 2012-04-27T10:04:43-04:00
    Scheduled time: None
    Result: None
    Exception: None
    Traceback: None


[root@pulp-v1-1-server ~]#

Comment 5 Preethi Thomas 2012-05-25 14:14:35 UTC
Pulp v1.1 Release