Bug 815563

Summary: System preferences dialog needs new at-spi locators
Product: Red Hat Enterprise Linux 6 Reporter: J.C. Molet <jmolet>
Component: subscription-managerAssignee: Bryan Kearney <bkearney>
Status: CLOSED ERRATA QA Contact: J.C. Molet <jmolet>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.3CC: awood, mstead, syeghiay
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 12:56:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 738066    
Attachments:
Description Flags
system prefs none

Description J.C. Molet 2012-04-23 21:09:34 UTC
Description of problem:
It looks like the glade file for the System Preferences dialog in subscription-manager-gui has been copied directly from the register dialog and modified for special use.  Normally that's cool, but it seems that none of the at-spi locators were changed, so everything still says "register_dialog" instead of "system-preferences", so it is very confusing.


Version-Release number of selected component (if applicable):
subscription-manager-gnome-1.0.0-1.git.32.1d1ef82.el6_2.x86_64

How reproducible:
always

Steps to Reproduce:
1. Open the system preferences dialog and then look at the locators through your favorite at-spi broswer (like sniff from the dogtail package).
  
Actual results:
in the file: 
subscription-manager/src/subscription_manager/gui/data/preferences.glade

you have the following lines for

The window title:  
<atkproperty name="AtkObject::accessible-name">register_dialog</atkproperty>

The vbox containing the elements:
<atkproperty name="AtkObject::accessible-name" translatable="yes">register_dialog_main_vbox</atkproperty>

The action area:
<atkproperty name="AtkObject::accessible-name" translatable="yes">registration_dialog_action_area
</atkproperty>

The close button:
<atkproperty name="AtkObject::accessible-name" translatable="yes">register_button</atkproperty>
<atkproperty name="AtkObject::accessible-description">register_button</atkproperty>

Expected results:

All of the <accessibility> </accessibility> sections could be removed; window titles and button objects are automatically given an at-spi locator of the same name.  Additionally the vbox and action-area only serve as organizational divisions and are not usable or clickable - therefore don't really NEED a locator either though they could be simply renamed.

Additional info:

Comment 1 Alex Wood 2012-04-24 14:33:09 UTC
commit 39ce1eacf41671011eadd357648d3e5db890d87b
Author: Alex Wood <awood>
Date:   Tue Apr 24 10:26:36 2012 -0400

    815563: Remove incorrect at-spi locators.

Comment 2 Alex Wood 2012-04-24 14:49:22 UTC
Committed 51da3ce32a059800a66bbb83935df593337998d0 to RHEL6.3

Comment 6 J.C. Molet 2012-04-26 14:34:44 UTC
Created attachment 580499 [details]
system prefs

subscription-manager-gnome-1.0.0-1.git.39.fc7bf19.el6_2.x86_64


Fixed in the above version.

All things are named properly and all traces of register_dialog have been removed from this window.

Comment 8 errata-xmlrpc 2012-06-20 12:56:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0804.html