Bug 815601

Summary:	csprocessor status is misleading
Product:	[Community] PressGang CCMS	Reporter:	Joshua Wulf <jwulf>
Component:	CSProcessor	Assignee:	Lee Newson <lnewson>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.x	CC:	jwulf, lcarlon
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	0.23.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-07 01:30:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joshua Wulf 2012-04-24 03:07:16 UTC

After performing extensive edits to my local content spec, csprocessor status tells me:

"The local copy of the Content Specification is up to date."

I'm expecting it to inform me: "You have unsaved local changes".


cspclient-0.23.2-1.noarch
OS: Fedora release 15 (Lovelock)

JAVA: java version "1.7.0_01"
Java(TM) SE Runtime Environment (build 1.7.0_01-b08)
Java HotSpot(TM) 64-Bit Server VM (build 21.1-b02, mixed mode)

Comment 1 Lee Newson 2012-04-24 04:04:12 UTC

Confirmed. The issue is that the local copy is only checked for it's checksum value then compared to the server copy. The checksum from the local copy should be calculated from it's content.

Comment 2 Lee Newson 2012-04-29 22:55:47 UTC

Added in 0.23.3

This is actually an addition because the original feature request just asked to see if the server copy had been changed so that you knew if you had to do a pull to get the latest content.

Now you will get the error:

"The local copy of the Content Specification is out of date. Please use "csprocessor pull" to download the latest copy."

If the server copy has been updated in comparison to the local copy (this is how the command currently works). If the local copy has been updated and still matches the servers checksum then you will get the following error message:

"The local copy of the Content Specification has been updated and is out of sync with the server. Please use "csprocessor push" to update the server copy."

Comment 3 Joshua Wulf 2012-05-01 01:02:50 UTC

Great!

What about case 3:

"You have unsaved changes in your local content spec, but the server copy has been modified since you last synchronised. Use "csprocessor pull" to update your local copy. Your unsaved local changes will be saved as <filename>.backup."

Comment 4 Lee Newson 2012-05-10 03:24:19 UTC

Added in 0.23.3 as well.

The output for the third case is: 

ERROR: The local copy and server copy of the Content Specification has been updated. Please use \"csprocessor pull\" to update your local copy. Your unsaved local changes will be saved as Development_Guide-post.backup.

Comment 5 Lee Newson 2013-06-07 01:30:52 UTC

Closing and setting as current release as no QA was performed by the original reporter. If there is still an issue with this bug still than please re-open it.