Bug 815605

Summary: PATCH: screen does not properly handle crypt() returning NULL
Product: [Fedora] Fedora Reporter: Paul Wouters <pwouters>
Component: screenAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: lnykryn
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: screen-4.1.0-0.10.20120314git3c2946.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-26 10:44:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch hanlding crypt() returning NULL none

Description Paul Wouters 2012-04-24 03:50:37 UTC 
crypt() can return NULL, but screen uses functions like strcmp() directly on the return value of crypt().

crypt() can return NULL when the system is in fips mode and the hashing algorithm passed via the salt value is not allowed (eg md5)

Attached is a patch
Comment 1 Paul Wouters 2012-04-24 03:51:18 UTC 
Created attachment 579740 [details]
patch hanlding crypt() returning NULL
Comment 2 Lukáš Nykrýn 2012-04-26 08:50:27 UTC 
Thanks for the patch, I have also sent it to upstream.
Comment 3 Lukáš Nykrýn 2012-04-26 10:44:56 UTC 
patch committed to git-> http://lists.fedoraproject.org/pipermail/scm-commits/