Bug 817498

Summary: Please update to 2.5.x on F17
Product: [Fedora] Fedora Reporter: Mary Ellen Foster <mefoster>
Component: jgoodies-looksAssignee: Mohamed El Morabity <pikachu.2014>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: pikachu.2014
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-01 17:06:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Necessary spec file change to include icons
none
Updated diff none

Description Mary Ellen Foster 2012-04-30 09:34:26 UTC
Description of problem:
jgoodies-common on F17 is version 1.3.0. Among the changes in this version are:
- Removed *SystemUtils#IS_JAVA_5
- Removed SystemUtils#IS_JAVA_6_OR_LATER

However, jgoodies-looks on F17 is still 2.4.2 and appears to rely on IS_JAVA_5.

The newest Rawhide version seems to be 2.5.0 -- 2.5.1 was actually released earlier in April, so that would be even better, but F17 definitely needs at least 2.5.0.

Version-Release number of selected component (if applicable):
jgoodies-looks-2.4.2-3.fc17.noarch

How reproducible:
Every time

Steps to Reproduce:
1. yum install icegrid-gui
2. icegridgui
  
Actual results:
Exception in thread "AWT-EventQueue-0" java.lang.NoSuchFieldError: IS_JAVA_5
        at com.jgoodies.looks.plastic.PlasticPasswordFieldUI.create(PlasticPasswordFieldUI.java:75)
        at javax.swing.plaf.basic.BasicTextUI.modelChanged(BasicTextUI.java:684)
        at javax.swing.plaf.basic.BasicTextUI$UpdateHandler.propertyChange(BasicTextUI.java:1788)
[...]

Expected results:
IceGrid GUI comes up

Comment 1 Mohamed El Morabity 2012-05-03 12:31:00 UTC
Thanks for your bug report, I'm currently fixing it.

Comment 2 Fedora Update System 2012-05-10 22:55:28 UTC
jgoodies-forms-1.5.1-1.fc17,jgoodies-looks-2.5.1-1.fc17,jgoodies-common-1.3.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/jgoodies-forms-1.5.1-1.fc17,jgoodies-looks-2.5.1-1.fc17,jgoodies-common-1.3.1-1.fc17

Comment 3 Fedora Update System 2012-05-11 21:51:19 UTC
Package jgoodies-forms-1.5.1-1.fc17, jgoodies-looks-2.5.1-1.fc17, jgoodies-common-1.3.1-1.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing jgoodies-forms-1.5.1-1.fc17 jgoodies-looks-2.5.1-1.fc17 jgoodies-common-1.3.1-1.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-7707/jgoodies-forms-1.5.1-1.fc17,jgoodies-looks-2.5.1-1.fc17,jgoodies-common-1.3.1-1.fc17
then log in and leave karma (feedback).

Comment 4 Mary Ellen Foster 2012-05-18 09:55:17 UTC
Created attachment 585376 [details]
Necessary spec file change to include icons

This new package doesn't include the icons in the jar file any more, which breaks (for example) JFileChoosers.

The attached patch to the spec file (moving the icons into a "resources" directory before building) fixes the problem.

Comment 5 Mohamed El Morabity 2012-05-18 10:08:07 UTC
Many thanks for the patch! After some debug sessions on icegridgui, I realized too that the missing resources explain its crash with jgoodies-looks-2.5.1-1.fc17.
I will merge your fix and build a new version of jgoodies-looks tonight.

Comment 6 Mary Ellen Foster 2012-05-18 10:46:53 UTC
Created attachment 585389 [details]
Updated diff

Here's an updated diff -- it would appear that there's also a necessary resource in the "common" directory

Comment 7 Fedora Update System 2012-05-19 18:34:15 UTC
Package jgoodies-forms-1.5.1-1.fc17, jgoodies-common-1.3.1-1.fc17, jgoodies-looks-2.5.1-2.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing jgoodies-forms-1.5.1-1.fc17 jgoodies-common-1.3.1-1.fc17 jgoodies-looks-2.5.1-2.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-7707/jgoodies-forms-1.5.1-1.fc17,jgoodies-looks-2.5.1-2.fc17,jgoodies-common-1.3.1-1.fc17
then log in and leave karma (feedback).

Comment 8 Mary Ellen Foster 2012-05-25 11:17:18 UTC
Thanks for that!

It seems that the packaging on Rawhide is now different from on F17, in two ways:
- It includes 2.5.0 instead of 2.5.1
- It has a jgoodies-looks directory containing several jars instead of a single jgoodies-looks jar

Is it possible to unify the two packages somehow? Is the rawhide package structure the way of the future?

Comment 9 Fedora Update System 2012-06-01 17:06:09 UTC
jgoodies-forms-1.5.1-1.fc17, jgoodies-common-1.3.1-1.fc17, jgoodies-looks-2.5.1-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.