Bug 818629
Summary: | Review Request: rubygem-delayed_job_active_record - ActiveRecord back-end for DelayedJob | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
Component: | Package Review | Assignee: | Richard Su <rwsu> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jstribny, notting, package-review, rwsu |
Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-12-11 15:21:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Vít Ondruch
2012-05-03 15:14:25 UTC
Hi, 1, rpmlint gives me no errors on .spec file and src.rpm: `0 packages and 1 specfiles checked; 0 errors, 0 warnings.` `1 packages and 0 specfiles checked; 0 errors, 0 warnings.` 2, The version of the gem in the spec file is 0.3.2, but 0.3.3 is already out: `gem fetch delayed_job_active_record` `Fetching: delayed_job_active_record-0.3.3.gem (100%)` It's recommended to always build for the latest upstream release if available. 3, Running: `mock -r fedora-rawhide-x86_64 rubygem-delayed_job_active_record-0.3.2-1.fc19.src.rpm` raises an exception, in the build.log I found a failing test: ``` + rspec spec DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use `self.primary_key = 'the_name'` instead. (called from <class:Story> at /builddir/build/BUILD/rubygem-delayed_job_active_record-0.3.2/usr/share/gems/gems/delayed_job_active_record-0.3.2/spec/spec_helper.rb:43) ............................................................F................ Failures: 1) Delayed::Backend::ActiveRecord::Job it should behave like a delayed_job backend worker integration failed jobs should re-schedule jobs after failing Failure/Error: @job.attempts.should == 1 expected: 1 ``` This also happens when building using mock for fedora-18-x86_64. Thank you for looking into this package. Here is its updated version: Spec URL: http://people.redhat.com/vondruch/rubygem-delayed_job_active_record.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-delayed_job_active_record-0.3.3-1.fc19.src.rpm (In reply to comment #1) > 2, The version of the gem in the spec file is 0.3.2, but 0.3.3 is already > out: > > `gem fetch delayed_job_active_record` > `Fetching: delayed_job_active_record-0.3.3.gem (100%)` > > It's recommended to always build for the latest upstream release if > available. Yes, the .spec file was laying around for some time. I updated it to the latest version. > 3, Running: > > `mock -r fedora-rawhide-x86_64 > rubygem-delayed_job_active_record-0.3.2-1.fc19.src.rpm` raises an exception, > in the build.log I found a failing test: > ``` > + rspec spec > DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use > `self.primary_key = 'the_name'` instead. (called from <class:Story> at > /builddir/build/BUILD/rubygem-delayed_job_active_record-0.3.2/usr/share/gems/ > gems/delayed_job_active_record-0.3.2/spec/spec_helper.rb:43) > ............................................................F................ > Failures: > 1) Delayed::Backend::ActiveRecord::Job it should behave like a delayed_job > backend worker integration failed jobs should re-schedule jobs after failing > Failure/Error: @job.attempts.should == 1 > expected: 1 > ``` > > This also happens when building using mock for fedora-18-x86_64. Weird. You can see from the attached Koji link that the test suite used to pass. However, it was probably against Rails 3.0 at that time. I was not able to locate the issue, so I have reported it upstream: https://github.com/collectiveidea/delayed_job_active_record/issues/24 Seems like that upstream is not doing anything about the issue for the time being. The package is otherwise okay => APPROVED. No SCM request found in bug 818629. Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-delayed_job_active_record Short Description: ActiveRecord back-end for DelayedJob Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). |