Bug 818848

Summary:	No error messages print when set --spice-disable-effects and other spice options with wrong value
Product:	Red Hat Enterprise Linux 6	Reporter:	tingting zheng <tzheng>
Component:	spice-gtk	Assignee:	Christophe Fergeau <cfergeau>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.3	CC:	acathrow, cfergeau, dblechte, dyasny, gkong, jwu, lcui, mkrcmari, mzhan, rwu, yupzhang, zpeng
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spice-gtk-0.14-1.el6	Doc Type:	Bug Fix
Doc Text:	Cause: Consequence: No error messages printed when qemu is started with --spice-disable-effects with an invalid value Fix: Exit qemu when such an invalid value is encountered Result:	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 08:47:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description tingting zheng 2012-05-04 07:47:19 UTC

Description of problem:
No error messages print when set --spice-disable-effects with wrong value,also it occurs with the below spice options:
--spice-ca-file, --spice-host-subject, --spice-smartcard-certificates, --spice-smartcard-db,--spice-usbredir-filter

Version-Release number of selected component (if applicable):
virt-viewer-0.5.2-6.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Configure a guest with spice.
2. # virt-viewer --help-spice
Usage:
  virt-viewer [OPTION...] DOMAIN-NAME|ID|UUID - Virtual machine graphical console

Spice Options:
……
  --spice-ca-file=<file>                                            Truststore file for secure connections
  --spice-host-subject=<host-subject>                               Subject of the host certificate (field=value pairs separated by commas)
  --spice-smartcard-certificates=<certificates>                     Certificates to use for software smartcards (field=values separated by commas)
  --spice-smartcard-db=<certificate-db>                             Path to the local certificate database to use for software smartcard certificates
  --spice-usbredir-filter=<filter-string>                           Filter for excluding USB devices from auto redirection
……

3. Use virt-viewer or remote-viewer with --spice-disable-effects to open the guest,set invalid value such as test.
# virt-viewer rhel6-spice --spice-disable-effects=test --debug
** (virt-viewer:4625): DEBUG: fullscreen display 0: 0
** (virt-viewer:4625): DEBUG: fullscreen display 0: 0
** (virt-viewer:4625): DEBUG: Opening connection to libvirt with URI <null>

** (virt-viewer:4625): DEBUG: Add handle 7 1 0x1cf6cc0
** (virt-viewer:4625): DEBUG: Add timeout 0x1cf6760 -1 0x7f2f4fdc5550 0x1cf6b10 1
** (virt-viewer:4625): DEBUG: notebook show status 0x1c8e1d0
** (virt-viewer:4625): DEBUG: notebook show status 0x1c8e1d0
** (virt-viewer:4625): DEBUG: Guest rhel6-spice is running, determining display

** (virt-viewer:4625): DEBUG: Set connect info: (null),(null),(null),-1,(null),(null),(null),0
** (virt-viewer:4625): DEBUG: Guest rhel6-spice has a spice display

** (virt-viewer:4625): DEBUG: Guest graphics address is 0.0.0.0:5900
** (virt-viewer:4625): DEBUG: Guest graphics listen '0.0.0.0' is NULL or a wildcard, replacing with 'localhost'
** (virt-viewer:4625): DEBUG: Set connect info: localhost,localhost,5900,-1,(null),(null),(null),0
** (virt-viewer:4625): DEBUG: Error operation virDomainOpenGraphics forbidden for read only access
** (virt-viewer:4625): DEBUG: After open connection callback fd=-1
** (virt-viewer:4625): DEBUG: Opening direct TCP connection to display at localhost:5900:-1

** (virt-viewer:4625): DEBUG: notebook show status 0x1c8e1d0
** (virt-viewer:4625): DEBUG: Add timeout 0x1d14ac0 -1 0x7f2f4fd3a530 0x1cf6340 2
** (virt-viewer:4625): DEBUG: main channel: opened
** (virt-viewer:4625): DEBUG: new audio channel
** (virt-viewer:4625): DEBUG: notebook show status 0x1c8e1d0
** (virt-viewer:4625): DEBUG: new display channel (#0)
** (virt-viewer:4625): DEBUG: notebook show status 0x1c8e1d0
** (virt-viewer:4625): DEBUG: new inputs channel
** (virt-viewer:4625): DEBUG: Display size request 100x100 (desktop 100x100)
** (virt-viewer:4625): DEBUG: Allocated 400x375
** (virt-viewer:4625): DEBUG: Child allocate 375x375
** (virt-viewer:4625): DEBUG: Display size request 50x50 (desktop 100x100)
** (virt-viewer:4625): DEBUG: Allocated 400x375
** (virt-viewer:4625): DEBUG: Child allocate 375x375
** (virt-viewer:4625): DEBUG: spice desktop resize 1024x768
** (virt-viewer:4625): DEBUG: Preparing main window resize
** (virt-viewer:4625): DEBUG: Decided todo 1024x768 (desktop is 1024x768, fullscreen is 1280x1024
** (virt-viewer:4625): DEBUG: Display size request 1024x768 (desktop 1024x768)
** (virt-viewer:4625): DEBUG: Allocated 1024x768
** (virt-viewer:4625): DEBUG: Child allocate 1024x768
** (virt-viewer:4625): DEBUG: Display size request 50x50 (desktop 1024x768)
** (virt-viewer:4625): DEBUG: Allocated 1024x768
** (virt-viewer:4625): DEBUG: Child allocate 1024x768
** (virt-viewer:4625): DEBUG: display mark 1
** (virt-viewer:4625): DEBUG: notebook show display 0x1c8e1d0
** (virt-viewer:4625): DEBUG: Window closed
** (virt-viewer:4625): DEBUG: main channel: closed
** (virt-viewer:4625): DEBUG: zap session channel (#0)
** (virt-viewer:4625): DEBUG: zap main channel
** (virt-viewer:4625): DEBUG: notebook show status 0x1c8e1d0
** (virt-viewer:4625): DEBUG: Guest rhel6-spice display has disconnected, shutting down
** (virt-viewer:4625): DEBUG: Set connect info: (null),(null),(null),-1,(null),(null),(null),0


Actual results:
No error messages print when set --spice-disable-effects and other spice options with wrong value

Expected results:
Messages print like:value for --spice-disable-effects can set as <wallpaper,font-smooth,animation,all>

Additional info:

Comment 2 Daniel Berrangé 2012-07-26 17:35:59 UTC

These command line args are all handled by spice-client-gtk rather than virt-viewer

Comment 3 Christophe Fergeau 2012-08-10 15:53:07 UTC

I just sent a patch to fix this to the spice-devel mailing list:
http://lists.freedesktop.org/archives/spice-devel/2012-August/010379.html

Comment 7 errata-xmlrpc 2013-02-21 08:47:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0343.html