Bug 820350
| Summary: | Review Request: shellinabox - Web based AJAX terminal emulator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simone Caronni <negativo17> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jochen.wiedmann, lemenkov, notting, package-review |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-11 13:26:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Simone Caronni
2012-05-09 18:12:48 UTC
Small changes to make sure it also builds on RHEL/CentOS 5 beside Fedora 15/16/17 and RHEL/CentOS 6. Spec URL: http://slaanesh.fedorapeople.org/shellinabox.spec SRPM URL: http://slaanesh.fedorapeople.org/shellinabox-2.14-2.fc17.src.rpm Thanks, --Simone *** Bug 619228 has been marked as a duplicate of this bug. *** I'll review this. REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is not completely silent: sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/shellinabox-* ../SRPMS/shellinabox-2.14-2.fc18.src.rpm shellinabox.ppc: W: incoherent-version-in-changelog 2.14-1 ['2.14-2.fc18', '2.14-2'] ^^^ please adjust your top-level %changelog section to match the package's actual EVR. shellinabox.ppc: W: only-non-binary-in-usr-lib ^^^ bogus message. shellinabox.src:19: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) ^^^ cosmetic / easyfix. Not a blocker (but I advise you to fix it anyway) shellinabox.src: W: invalid-url Source0: http://shellinabox.googlecode.com/files/shellinabox-2.14.tar.gz HTTP Error 404: Not Found ^^^ bogus message. 3 packages and 0 specfiles checked; 0 errors, 4 warnings. sulaco ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv2 only with OpenSSL linking exception, as stated in the sources). - The file, containing the text of the license(s) for the package, MUST BE included in %doc. Please mark COPYING and GPL-2 as %doc + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. sulaco ~/rpmbuild/SOURCES: sha256sum shellinabox-2.14.tar.gz* 4126eb7070869787c161102cc2781d24d1d50c8aef4e5a3e1b5446e65d691071 shellinabox-2.14.tar.gz 4126eb7070869787c161102cc2781d24d1d50c8aef4e5a3e1b5446e65d691071 shellinabox-2.14.tar.gz.1 sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on my PowerPC box. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. So, please, add licensing info and I'll finish reviewing it. Thanks, added everything: - Spec file changes (changelog, formatting). - Added license files to doc section. Spec URL: http://slaanesh.fedorapeople.org/shellinabox.spec SRPM URL: http://slaanesh.fedorapeople.org/shellinabox-2.14-3.fc17.src.rpm (In reply to comment #5) > Thanks, > > added everything: > > - Spec file changes (changelog, formatting). > - Added license files to doc section. > > Spec URL: http://slaanesh.fedorapeople.org/shellinabox.spec > SRPM URL: http://slaanesh.fedorapeople.org/shellinabox-2.14-3.fc17.src.rpm Good. I can't find any other issues so this package is APPROVED. New Package SCM Request ======================= Package Name: shellinabox Short Description: Web based AJAX terminal emulator Owners: slaanesh Branches: f17 f16 f15 el6 el5 InitialCC: Git done (by process-git-requests). |