Bug 821582

Summary:	Read-only project page should show "active" versions as being read-only, not active
Product:	[Retired] Zanata	Reporter:	Joyce Chang <jochang>
Component:	Usability	Assignee:	Alex Eng <aeng>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ding-Yi Chen <dchen>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	1.6-SNAPSHOT	CC:	aeng, petersen, sflaniga, zanata-bugs
Target Milestone:	---
Target Release:	2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	1.8.0-SNAPSHOT (20120809-0024)	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-11-07 06:19:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joyce Chang 2012-05-15 02:29:19 UTC

Description of problem:
If the status of a project is changed from active to read-only, it should be re-categorised into read-only instead of active. But the current behaviour of the project being changed its status from active to read-only, is still tagged as active under active versions. 


Version-Release number of selected component (if applicable):
1.6.0-alpha-3-SNAPSHOT

How reproducible:


Steps to Reproduce:
1.login as admin/project maintainer 
2.pick up an active project and click "Edit Project"
3.change status to read-only
  
Actual results:
the project is still tagged as active. 

Expected results:
the project would be tagged as read-only instead of active

Additional info:
changing status to Obsolete works properly

Comment 1 Sean Flanigan 2012-05-29 00:38:57 UTC

Please re-test with latest code.

Comment 2 Joyce Chang 2012-05-31 02:54:27 UTC

still reproducible in Zanata version 1.6.0-beta-2-SNAPSHOT (20120531-0020). 

When the project itself was set to read-only,the version underneath should become read-only regardless its previous status

Comment 3 Sean Flanigan 2012-05-31 03:45:23 UTC

When this happens, does the user at least get a permission error when trying to save changes?

Comment 4 Joyce Chang 2012-05-31 04:17:09 UTC

Nothing happens where users can successfully save changes without getting an error.

Comment 5 Sean Flanigan 2012-05-31 04:45:52 UTC

Sorry, I was thinking that this was about whether the translation editor showed up in read-only mode, but that was another bug entirely.  This is about the list of versions shown on the project page.

Comment 6 Joyce Chang 2012-05-31 05:34:50 UTC

oops, sorry for the confusion if my description is not clear enough

Comment 7 Alex Eng 2012-07-30 05:55:49 UTC

With current implementation, if a project is read-only, the "translate" link in each of the version regardless their status is changed to "Open" which reflect read-only mode. Is that sufficient enough to determine the action?

Comment 8 Alex Eng 2012-07-31 00:56:16 UTC

Implemented fix. 

See https://github.com/zanata/zanata/commit/dd10a5eaba7f725eabfcd071b8552913c347f300

Comment 9 Alex Eng 2012-08-05 23:15:03 UTC

Implemented UI changes on versions when project status changed.

See https://github.com/zanata/zanata/commit/4b69cd1c917af7f30f6f13f6cc119fde1aa35a32

Comment 10 Ding-Yi Chen 2012-08-09 03:57:36 UTC

VERIFIED with 1.8.0-SNAPSHOT (20120809-0024)

Comment 11 Sean Flanigan 2012-11-07 06:19:20 UTC

Fix released in Zanata 2.0.