Bug 822119

Summary: [cli] repo create without "http://" in url - python traceback
Product: Red Hat Satellite Reporter: Garik Khachikyan <gkhachik>
Component: APIAssignee: Bryan Kearney <bkearney>
Status: CLOSED ERRATA QA Contact: Garik Khachikyan <gkhachik>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.1CC: achan, asettle, dmacpher, mkoci, mmccune, omaciel
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Traceback errors occur when running repository creation on the command line without the "http://" prefix. This fix changes the behavior to issue an error advising the user to add the "http://" prefix.
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 19:45:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Garik Khachikyan 2012-05-16 11:55:54 UTC
Description of problem:
Recent CFSE returns with traceback when repo create proceeds with url like: "inecas.fedorapeople.org/fakerepos/zoo3" (without 'http://' there)

Version-Release number of selected component (if applicable):
katello-common-0.1.311-1.el6_2.noarch
candlepin-0.5.26-1.el6.noarch
qpid-cpp-client-0.14-14.el6_2.x86_64
pulp-1.0.4-1.el6.noarch
qpid-cpp-client-ssl-0.14-14.el6_2.x86_64
katello-qpid-client-key-pair-1.0-1.noarch
katello-cli-common-0.1.107-1.el6.noarch
katello-cli-0.1.107-1.el6.noarch
mod_wsgi-3.3-3.pulp.el6.x86_64
python-qpid-0.14-7.el6_2.noarch
python-isodate-0.4.4-4.pulp.el6.noarch
katello-certs-tools-1.0.4-1.el6.noarch
katello-glue-candlepin-0.1.311-1.el6_2.noarch
pulp-selinux-server-1.0.4-1.el6.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
katello-agent-0.17-1.el6.noarch
pulp-common-1.0.4-1.el6.noarch
katello-glue-foreman-0.1.311-1.el6_2.noarch
katello-0.1.311-1.el6_2.noarch
katello-configure-0.1.107-1.el6.noarch
candlepin-tomcat6-0.5.26-1.el6.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
python-oauth2-1.5.170-2.pulp.el6.noarch
katello-glue-pulp-0.1.311-1.el6_2.noarch
qpid-cpp-server-0.14-14.el6_2.x86_64
katello-selinux-0.1.10-1.el6.noarch
qpid-cpp-server-ssl-0.14-14.el6_2.x86_64
m2crypto-0.21.1.pulp-7.el6.x86_64


How reproducible:
always on recent CFSE

Steps to Reproduce:
1.create prov/prod for an org.
2.create repo with: --url inecas.fedorapeople.org/fakerepos/zoo3
3.
  
Actual results:
traceback:
---
cfse> repo create --name zoo3 --product zoo --url inecas.fedorapeople.org/fakerepos/zoo3
Traceback (most recent call last):\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/decorators.py\", line 48, in report_error\n    return method(self, *args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/decorators.py\", line 127, in _auth_decorator\n    value = method(self, *args, **kwargs)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/webservices/controllers/repositories.py\", line 333, in POST\n    publish=repo_data.get('publish', None),)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/api/repo.py\", line 246, in create\n    source = model.RepoSource(feed)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/db/model/resource.py\", line 329, in __init__\n    self.set_type(url)\n  File \"/usr/lib/python2.6/site-packages/pulp/server/db/model/resource.py\", line 339, in set_type\n    raise PulpException(\"Invalid url [%s]; please provide a valid url\" % url)\nPulpException: Invalid url [inecas.fedorapeople.org/fakerepos/zoo3]; please provide a valid url\n
---

Expected results:
no traceback but normal error string (with error code) back

Additional info:

Comment 1 Garik Khachikyan 2012-05-16 12:25:36 UTC
btw: latest katello has the fix:
---
katello> repo create --name zoo3 --product zoo --url inecas.fedorapeople.org/fakerepos/zoo3
Invalid Url
---

m2crypto-0.21.1.pulp-7.el6.x86_64
mod_wsgi-3.3-3.pulp.el6.x86_64
python-qpid-0.14-7.el6_2.noarch
katello-glue-candlepin-0.2.35-1.git.39.f968b3f.el6.noarch
pulp-1.0.4-1.el6.noarch
katello-repos-testing-0.2.4-1.el6.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
qpid-cpp-server-ssl-0.14-14.el6_2.x86_64
katello-agent-1.0.3-1.git.0.cccd0b4.el6.noarch
candlepin-0.5.32-1.el6.noarch
pulp-common-1.0.4-1.el6.noarch
katello-common-0.2.35-1.git.39.f968b3f.el6.noarch
pulp-selinux-server-1.0.4-1.el6.noarch
qpid-cpp-client-ssl-0.14-14.el6_2.x86_64
katello-cli-0.2.33-1.git.21.60dfa73.el6.noarch
katello-certs-tools-1.1.6-1.git.0.4878f30.el6.noarch
qpid-cpp-server-0.14-14.el6_2.x86_64
katello-glue-foreman-0.2.35-1.git.39.f968b3f.el6.noarch
katello-0.2.35-1.git.39.f968b3f.el6.noarch
katello-configure-0.2.20-1.git.23.a39fddd.el6.noarch
candlepin-tomcat6-0.5.32-1.el6.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
katello-cli-common-0.2.33-1.git.21.60dfa73.el6.noarch
python-oauth2-1.5.170-2.pulp.el6.noarch
qpid-cpp-client-0.14-14.el6_2.x86_64
katello-glue-pulp-0.2.35-1.git.39.f968b3f.el6.noarch
katello-selinux-0.2.4-1.git.0.b03a73e.el6.noarch
katello-repos-0.2.4-1.el6.noarch
katello-qpid-client-key-pair-1.0-1.noarch

Comment 2 Mike McCune 2012-05-16 15:33:26 UTC
moving ON_DEV since it is fixed in upstream

Comment 3 Garik Khachikyan 2012-05-17 14:36:51 UTC
acking.

Comment 5 Garik Khachikyan 2012-10-04 12:04:16 UTC
# VERIFIED

proper message is now returning back telling:
---
katello: error: option --url: has to start with http:// or https:// or ftp:// or file://
---

thanks a lot for the fixed.

checked on:
---
katello-1.1.12-12.el6cf.noarch
katello-cli-1.1.8-6.el6cf.noarch

Comment 7 errata-xmlrpc 2012-12-04 19:45:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-1543.html

Comment 8 Mike McCune 2013-08-16 18:07:14 UTC
getting rid of 6.0.0 version since that doesn't exist