Bug 823226
| Summary: | Review Request: sqlheavy - GObject wrapper for SQLite | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adrian Alves <aalves> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | aalves, misc, package-review, quantum.analyst, thomas.moschny |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-10-05 03:39:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Adrian Alves
2012-05-20 02:24:07 UTC
Hi, a few comment on the spec : - you should have a -devel subpackage for developpement related files ( .h, .pc, etc ) https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages - I am not sure, but I think there was some discussion regarding the place of vala files. However, that's not in the policy yet, so I would just suggest to keep a eye on it - the package do not compile on rawwhide ( it does on f17 however ). Not sure why, but you can check with mock. - the license tag is invalid https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names - there is no ldconfig call in %post, and that's kinda required https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries (In reply to comment #1) > Hi, > > a few comment on the spec : > - you should have a -devel subpackage for developpement related files ( .h, > .pc, etc ) > https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages > > > - I am not sure, but I think there was some discussion regarding the place > of vala files. However, that's not in the policy yet, so I would just > suggest to keep a eye on it > > - the package do not compile on rawwhide ( it does on f17 however ). Not > sure why, but you can check with mock. > > - the license tag is invalid > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Valid_License_Short_Names > > - there is no ldconfig call in %post, and that's kinda required > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries I added sub-package devel but not sure if that is correct: Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-2.fc16.src.rpm By the way fixed the license tag and added the ldconfig in post and postun Your %files section needs a bit of rework. See http://thm.fedorapeople.org/sqlheavy/sqlheavy.spec . Also, rpmlint warns about mixed tabs and spaces, maybe you want to recheck that and either use tabs or spaces for indention. (In reply to comment #3) > Your %files section needs a bit of rework. See > http://thm.fedorapeople.org/sqlheavy/sqlheavy.spec . > > Also, rpmlint warns about mixed tabs and spaces, maybe you want to recheck > that and either use tabs or spaces for indention. Added ur modifications: Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-3.fc16.src.rpm I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. This fails to build for me. A scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5403710 It doesn't seem like anyone replied. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |