Bug 823682
| Summary: | Review Request: gnome-shell-theme-adwaita - The Adwaita gnome-shell theme created by half_left | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Miller <maxamillion> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mario.blaettermann, notting, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-10 20:19:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Miller
2012-05-21 21:07:52 UTC
Some comments:
Themes for gnome-shell are not intended to be packaged for EPEL 5. That's why you have to remove the BuildRoot definition, the %clean section and the %defattr line from %files.
The folder defined in the %theme macro (for LICENSE) is already owned by gnome-themes-standard, also the folder %{_datadir}/themes/%{theme}. Well, we could decide to let co-own your package this folder, because the gnome-shell theme would even work without the Adwaita gtk themes. But in my mind it would be better to drop the ownership and add "Requires: gnome-themes-standard". Logically, the Adwaita shell theme is a useful add-on to the other Adwaita stuff and shouldn't be recognized as completely independent.
Any news...? Just a reminder ... Just a reminder, sent out once a month ... as usual ;) After a couple of unresponsive pings last months, I recognize this ticket as ultimately dead. I will close it now. If you really want to have it reviewed, please reopen it. |