Bug 823842

Summary: cifs: Cleanup TCP_SERVER_Info
Product: Red Hat Enterprise Linux 6 Reporter: Sachin Prabhu <sprabhu>
Component: kernelAssignee: Sachin Prabhu <sprabhu>
Status: CLOSED ERRATA QA Contact: Jian Li <jiali>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.4CC: cifs-maint, jiali, kzhang, nmurray, rwheeler
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: kernel-2.6.32-298.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-21 05:56:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 798385    

Description Sachin Prabhu 2012-05-22 09:56:12 UTC
Cleanup TCP_Server_Info

Backport of the following upstream patch

--
commit c3dccf48174e50668b7c63544ac8c60c07a45978
Author: Jeff Layton <jlayton>
Date:   Thu Jan 20 13:36:50 2011 -0500

cifs: TCP_Server_Info diet

Remove fields that are completely unused, and rearrange struct
according to recommendations by "pahole".

Before:

        /* size: 1112, cachelines: 18, members: 49 */
        /* sum members: 1086, holes: 8, sum holes: 26 */
        /* bit holes: 1, sum bit holes: 7 bits */
        /* last cacheline: 24 bytes */

After:

        /* size: 1072, cachelines: 17, members: 42 */
        /* sum members: 1065, holes: 3, sum holes: 7 */
        /* last cacheline: 48 bytes */

...savings of 40 bytes per struct on x86_64. 21 bytes by field removal,
and 19 by reorganizing to eliminate holes.

Signed-off-by: Jeff Layton <jlayton>
Signed-off-by: Steve French <sfrench.com>

--

Comment 2 RHEL Program Management 2012-07-27 16:21:16 UTC
This request was evaluated by Red Hat Product Management for
inclusion in a Red Hat Enterprise Linux release.  Product
Management has requested further review of this request by
Red Hat Engineering, for potential inclusion in a Red Hat
Enterprise Linux release for currently deployed products.
This request is not yet committed for inclusion in a release.

Comment 3 Jian Li 2012-08-01 06:15:28 UTC
regression test and sanityonly check.

Comment 4 Jarod Wilson 2012-08-16 21:21:50 UTC
Patch(es) available on kernel-2.6.32-298.el6

Comment 8 errata-xmlrpc 2013-02-21 05:56:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0496.html