Bug 824052
| Summary: | Review Request: fcitx-m17n - M17n Engine for Fcitx | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Liang Suilong <liangsuilong> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, panemade, wengxt |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-12 00:00:56 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Liang Suilong
2012-05-22 16:13:15 UTC
Review:- + Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094875 + rpmlint on rpms gave fcitx-m17n.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-m17n-0.1.2.tar.xz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + Source verified with upstream as (sha1sum) 98ba1d134085e75c92e5303f0d3a1d132fefe8c4 fcitx-m17n-0.1.2.tar.xz 98ba1d134085e75c92e5303f0d3a1d132fefe8c4 ../SOURCES/fcitx-m17n-0.1.2.tar.xz suggestions: 1) License tag should be LGPLv2+ 2) each pushd command should have corresponding popd. please add it in %build 3) Change the fcitx package to own only /usr/share/fcitx/inputmethod/ 4) The correct way to handle locale files is remove manually generation of %{name}.lang in spec file and use %find_lang %{name} at the end of %install section.
Please use this approach on all the fcitx packages. See https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
any update here? any update here? Can you please provide update here so that once package review completes and built in fedora, will be available for testing? liangsuilong, If you are busy with your work then please allow me to fix this package and request SCM for this package and build it in Fedora so that people can use this SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-m17n.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-m17n-0.1.2-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4328987 I upload a new SRPM and SPEC. Please continue to review it. Thank you. APPROVED. Hi Liang, If you are busy, can I request you to allow me to import this package and co-own with you this package? BTW, fcitx-m17n 0.1.3 is out, if you'd like to import, please import that one. It provides some important bugfixing and default setup adjustion, thanks! No response from reporter since last 4 months here. If you still want this package in fedora then just reopen this and request for git package module. For now closing... New Package SCM Request ======================= Package Name: fcitx-m17n Short Description: M17n Engine for Fcitx Owners: liangsuilong Branches: f16 f17 f18 el6 InitialCC: i18n-team Git done (by process-git-requests). fcitx-m17n-0.1.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fcitx-m17n-0.1.3-1.fc18 fcitx-m17n-0.1.3-1.fc18 has been pushed to the Fedora 18 testing repository. fcitx-m17n-0.1.3-1.fc18 has been pushed to the Fedora 18 stable repository. |