Bug 824057
| Summary: | Review Request: fcitx-hangul - Hangul Engine for Fcitx | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Liang Suilong <liangsuilong> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-11 04:27:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Liang Suilong
2012-05-22 16:21:07 UTC
Review:- + Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094896 + rpmlint on rpms gave fcitx-hangul.src: W: spelling-error %description -l en_US libhangul -> Hangul fcitx-hangul.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-hangul-0.1.1.tar.xz HTTP Error 404: Not Found fcitx-hangul.x86_64: W: spelling-error %description -l en_US libhangul -> Hangul fcitx-hangul.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-hangul-0.1.1/COPYING 2 packages and 0 specfiles checked; 1 errors, 3 warnings. + Source verified with upstream as (sha1sum) 45ce2f8ee5b9c1f7940bee5e0e424391602aa0e3 fcitx-hangul-0.1.1.tar.xz 45ce2f8ee5b9c1f7940bee5e0e424391602aa0e3 ../SOURCES/fcitx-hangul-0.1.1.tar.xz Suggestions: 1) each pushd command should have corresponding popd. please add it in %build 2) License should be GPLv2+ and BSD. Add comment above license tag like # The entire source code is GPLv2+ except symbol.txt which is BSD APPROVED. I seem to be overlooked for locale handling in fcitx packages.
The correct way to handle locale files is remove manually generation of %{name}.lang in spec file and use %find_lang %{name} at the end of %install section.
New Package SCM Request ======================= Package Name: fcitx-hangul Short Description: Hangul Engine for Fcitx Owners: liangsuilong Branches: f15 f16 f17 el6 InitialCC: i18n-team Git done (by process-git-requests). any update here? any update here? Can you please build the package in fedora so that it will be available for testing? liangsuilong, If you are busy with your work then please allow me to request SCM for this package and build it in Fedora so that people can use this. fcitx-hangul-0.1.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-hangul-0.1.1-1.fc16 fcitx-hangul-0.1.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-hangul-0.1.1-1.fc17 fcitx-hangul-0.1.1-1.fc17 has been pushed to the Fedora 17 testing repository. I suppose this can be closed as packages are already in repositories. |