Bug 824372
| Summary: | BeautifulSoup 4 disguised as 3 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Schwendt <bugs.michael> |
| Component: | python-BeautifulSoup | Assignee: | Nicolas Chauvet (kwizart) <kwizart> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 17 | CC: | kwizart, mcepl, mcepl, terje.rosten |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-09 22:55:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Schwendt
2012-05-23 11:10:09 UTC
Yeah, for python3 bs4 is required, hence this confusing move. The best option would be to create whole, new package bs4 with python2 and python3 subpackages, and remove pyhton3 subpackage from bs. Oh, btw, current F-17 package fails to rebuild (only in the python3 %check, though). You might want to add "|| :" to that check, so the build doesn't fail. (In reply to comment #2) > Oh, btw, current F-17 package fails to rebuild (only in the python3 %check, > though). You might want to add "|| :" to that check, so the build doesn't > fail. I think this is very unnice advice ... tests should be fixed, or when they are skipping maintainer should find out why. That's the whole point of _continuing_ to run the tests, but ignoring the results. That way, the test results enter the build.log for anyone to take a look at (including interested upstream maintainers, who don't support Python3 and 2to3 converted sources yet. It isn't "unnice advice". It's considered helpful by many packagers, who assume that instead they could only not run the tests at all. And in pkg it, for the failing build, that is even done already since February,
so this has been unneeded advice even: ;)
111 %check
112 %{__python} BeautifulSoupTests.py
113
114 %if 0%{?with_python3}
115 pushd beautifulsoup4-%{bs4}
116 %{__python3} -m unittest discover -s bs4 || :
117 %endif
(In reply to comment #4) > That way, the test results enter the build.log for anyone to take a look at > (including interested upstream maintainers, who don't support Python3 and > 2to3 converted sources yet. I don't think there is any hard rule on %check section, so it is up to the maintainer how she does it. However, it seems to me that this package is a right example why it is not a good idea: there are at least two failing tests in the package which doesn't seem to cause any activity on the side of maintainer. If the tests failed, I would hope that before packager would add @unittest.SkipTest she would investigate a bit what's the root cause of the issue and possibly filed upstream bug for it. Anyway, how I said, any packager can do whatever he feels is right. Package review for bs4: https://bugzilla.redhat.com/show_bug.cgi?id=838675 python-BeautifulSoup-3.2.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-BeautifulSoup-3.2.1-3.fc17 python-BeautifulSoup-3.2.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-BeautifulSoup-3.2.1-3.fc16 Package python-BeautifulSoup-3.2.1-3.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-BeautifulSoup-3.2.1-3.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-11321/python-BeautifulSoup-3.2.1-3.fc17 then log in and leave karma (feedback). python-BeautifulSoup-3.2.1-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. python-BeautifulSoup-3.2.1-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |