Bug 826130

1.0.1 hashes:

commit 13276c749f2b297a5ee3ebdd1af4e5c75e22a72f
BZ 796528 - updated tests
    
    Also removed older test "launch instances if user has no access to hardware profile" which
    doesn't seem to do what it describes anyway.

commit cb9a146f2d29c1f1a80c005a90420fe141249266
BZ 796528 - set CREATE_FAILED status for instances which failed to launch

commit 296b9d2a011462cb1860e2a4e9e0ba1874d7ddfd
 BZ 796528 - instance's config params are now handled from taskomatic
    
    Reason for moving this is that taskomatic's create_instance method automatically
    sets create_failed instance's method when an exception occurs and then reraises
    this exception which is handled in deployment's launch method. add_instance_config!
    method raises an exceptions too and in that case we want to set create_failed state
    too.

commit ed774884c97b7af47491274e1795ed137a3f3f9e
BZ 796528 - deployment launch refactoring
    
    This patch tries to partially cleanup huge deployment launch method,
    the behavior of this method should be unchanged.
    - Instance + InstanceParameter objects creation is moved to separate method
    - common_provider_accounts_for replaced with create_instances_with_params method:
        this method returns only first possible match (and keeps account's priority
        ordering by using ascending_by_priority scope)
    - instance's launch block (including config setup) moved to separate Instance#launch method
    - added :dependent => :destroy for events association, which I think is missing by mistake

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Faulty instances remained in perpetual “pending” state when launched. Users were unable to delete these instances. This update adds an exception to set faulty instances to “create_failed” status. Users can now delete these instances.

Created attachment 590838 [details]
Connection_timed_out

Tried to recreate the issue in several ways . 
Could not get an instance in Pending or New state .

Launched an instance with config-server down and it launched the instance in 
create_failed state.

With Rhev , launching the instance with long name also launch a create_failed instance.

Moving the bug to Verified state.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-1063.html