Bug 826462

Summary: [RHEVM] [backend] [Hot plug NIC] variables in error message are not substituted
Product: Red Hat Enterprise Virtualization Manager Reporter: Martin Pavlik <mpavlik>
Component: ovirt-engineAssignee: Greg Padgett <gpadgett>
Status: CLOSED CURRENTRELEASE QA Contact: Martin Pavlik <mpavlik>
Severity: medium Docs Contact:
Priority: low    
Version: 3.1.0CC: amureini, dyasny, gklein, iheim, lpeer, Rhev-m-bugs, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: si12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 810675, 830836, 833648    
Attachments:
Description Flags
screenshot of error message
none
vdsm.log + engine.log none

Description Martin Pavlik 2012-05-30 09:10:58 UTC
Created attachment 587652 [details]
screenshot of error message

Description of problem:
Variables ${action} ${type} are not substituted in error message which appears when user tries do deactivate VM NIC on VM which has unsupported OS. (see screenshot)

Version-Release number of selected component (if applicable):
oVirt Enterprise Virtualization Engine Manager Version: 3.1.0_0001-11.el6ev 

How reproducible:
100%

Steps to Reproduce:
1. create windows XP machine with at least one activated NIC
2. run VM
3. Virtual Machines ->  your machine -> Network interfaces -> active NIC -> Deactivate
  
Actual results:
Error message with without variable substitution appears 
Cannot ${action} ${type}. Guest OS version is not supported.

Expected results:
Error message with with proper variable substitution appears 

Additional info:

Comment 1 Martin Pavlik 2012-05-30 09:17:41 UTC
Created attachment 587655 [details]
vdsm.log + engine.log

Comment 2 Martin Pavlik 2012-05-30 09:18:06 UTC
Line from engine.log is 

2012-05-30 11:09:05,139 WARN  [org.ovirt.engine.core.bll.HotPlugUnplugVmNicCommand] (ajp--0.0.0.0-8009-8) CanDoAction of action HotPlugUnplugVmNic failed. Reasons:ACTION_TYPE_FAILED_GUEST_OS_VERSION_IS_NOT_SUPPORTED

Comment 3 Greg Padgett 2012-07-13 19:55:42 UTC
Patch submitted upstream: http://gerrit.ovirt.org/6249

Comment 4 Greg Padgett 2012-07-17 13:31:17 UTC
Commit: 0248b6b4f252018e4a5e9a10515df05636650835

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=0248b6b4f252018e4a5e9a10515df05636650835

Comment 5 Martin Pavlik 2012-07-27 12:56:45 UTC
Hi Greg,

I was trying to verify this bug, but I suspect that rhevm behavior was changed as described in 

https://bugzilla.redhat.com/show_bug.cgi?id=828854#c16

so there would be no error meessage any more. Can you confirm it please?

Comment 6 lpeer 2012-07-30 13:34:21 UTC
(In reply to comment #5)
> Hi Greg,
> 
> I was trying to verify this bug, but I suspect that rhevm behavior was
> changed as described in 
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=828854#c16
> 
> so there would be no error meessage any more. Can you confirm it please?

confirmed.