Bug 826542

Summary: [eap6] security subsystem module-option processing is not working right. Loads options as flat string.
Product: [Other] RHQ Project Reporter: Simeon Pinder <spinder>
Component: PluginsAssignee: Armine Hovsepyan <ahovsepy>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.4CC: hrupp, mfoley
Target Milestone: ---   
Target Release: JON 3.1.1   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 844672 (view as bug list) Environment:
Last Closed: 2013-09-03 11:12:07 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 844672    
Description Flags
security subsystem -> security domain ->login models -> module options none

Description Simeon Pinder 2012-05-30 09:09:54 EDT
Description of problem: 
For the security subystem, the module-options are how parameters are passed to the underlying classes that implement security.  Ex. UserRoles authentication needs both 'user.properties' and 'role.properties' defined as separate module-options.  The current implementation loads all existing module-options as a single string instead of a map which is not very readable(Ex. the LDAP module has 12 such module mappings).  However writing new properties back does not work either. 

This works well in the console now.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Use the AS7 console to add a Security Domain to the security subsystem and via Authentication add a 'Login Module' and 2 Module Option. Save. 
2. Using RHQ plugin if you browse the AS7 instance the Login Module is loaded correctly, but all Module Options are displayed as single string. 
3. Attempt to add a new property using same format that the other properties are in and hit save(Ex. [{username=test1},{username2=test2}]).
Actual results:
i)single string display
ii)updating new property fails with
{JBAS014653: Composite operation failed and was rolled back. Steps that failed:={Operation step-1=[JBAS014798: Validation failed for value, JBAS014746: code may not be null]}}, rolled-back=true 

Expected results:
i)better display
ii)update does not fail.

Additional info:
Comment 1 Simeon Pinder 2012-06-07 15:20:17 EDT
This JIRA is related to getting module-option processing support correct:
Comment 2 Charles Crouch 2012-06-11 10:50:15 EDT
Targeting for jon311, assuming associated AS7 issues are addressed.
Comment 3 Simeon Pinder 2012-06-19 09:35:35 EDT
The code changes to fix this issue are in 2918e9c7df1d792b2b91f.  Although I'll need to update the unit test.  I forgot it was in the commit squash. Moving this to ON_QA but will also put in the commit hash where the unit test will be enhanced to work or be disabled.
Comment 4 Simeon Pinder 2012-06-20 08:58:39 EDT
Here's the second commit (51d5d2537e1dc1) to disable the unit tests that will require more work to get running in master.
Comment 5 Armine Hovsepyan 2012-08-01 07:32:19 EDT
Created attachment 601715 [details]
security subsystem -> security domain ->login models -> module options

Comment 6 Heiko W. Rupp 2013-09-03 11:12:07 EDT
Bulk closing of old issues in VERIFIED state.