Bug 826707
| Summary: | rpm verify fails for hardlinked sources in kernel-devel | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Backes <rtc> |
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | daveg, gansalmon, itamar, jforbes, jonathan, kernel-maint, madhu.chinakonda, pmatilai, public.oss, robatino, samuel.rakitnican |
| Target Milestone: | --- | Keywords: | FutureFeature, Triaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-09 21:28:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Backes
2012-05-30 20:01:15 UTC
If we get around to fixing this, it'll be in rawhide. This isn't a high priority issue by any means. The %verify(not mtime) approach seems quite reasonable to be, anything more complicated is not really worth the effort just for a bunch of timestamps. Depending on how the -devel package is constructed, it might be easier to use %defverify(not mtime) to declare defaults for the whole thing (assuming %defverify() actually works... I dont recall ever seeing that used in real-world, but if it doesn't you get to hand the bug over to rpm :) The main concern for me is when all the mtime output makes it impossible (without using grep) to see more serious issues, like missing files - for example see https://www.virtualbox.org/ticket/10847 where the System.map file in kernel-devel is missing. I only noticed it because it prevents kernel-devel drpms from working, so the full package must be downloaded. If someone wants to test it... Single line added to spec file on the git master branch dated 2012-10-23:
$ fedpkg clone --anonymous kernel
$ fedpkg switch-branch master
$ fedpkg pull
# edit
$ fedpkg diff
diff --git a/kernel.spec b/kernel.spec
index 520615e..fbc3d3f 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -2273,6 +2273,7 @@ fi
%ghost /boot/initramfs-%{KVERREL}%{?2:.%{2}}.img\
%{expand:%%files %{?2:%{2}-}devel}\
%defattr(-,root,root)\
+%defverify(not mtime)\
/usr/src/kernels/%{KVERREL}%{?2:.%{2}}\
%{expand:%%files %{?2:%{2}-}modules-extra}\
%defattr(-,root,root)\
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 (In reply to DaveG from comment #4) > If someone wants to test it... Single line added to spec file on the git > master branch dated 2012-10-23: > > $ fedpkg clone --anonymous kernel > $ fedpkg switch-branch master > $ fedpkg pull > # edit > $ fedpkg diff > diff --git a/kernel.spec b/kernel.spec > index 520615e..fbc3d3f 100644 > --- a/kernel.spec > +++ b/kernel.spec > @@ -2273,6 +2273,7 @@ fi > %ghost /boot/initramfs-%{KVERREL}%{?2:.%{2}}.img\ > %{expand:%%files %{?2:%{2}-}devel}\ > %defattr(-,root,root)\ > +%defverify(not mtime)\ > /usr/src/kernels/%{KVERREL}%{?2:.%{2}}\ > %{expand:%%files %{?2:%{2}-}modules-extra}\ > %defattr(-,root,root)\ Patch works! $ rpm -qV kernel-devel-4.3.5-300.defverify_not_mtime.fc23.x86_64 Returns nothing $ rpm -qvV kernel-devel-4.3.5-300.defverify_not_mtime.fc23.x86_64 | head -50 | fpaste http://paste.fedoraproject.org/332988/45701718/ I would like to see this fixed as well. This should be fixed in the current builds for rawhide and F24, it will trickle down through the usual rebase process. Seems to work as of f25 |