Bug 826819

Summary: Submodules in git repo fail to restore
Product: OKD Reporter: Jhon Honce <jhonce>
Component: ContainersAssignee: Rob Millner <rmillner>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 2.xCC: bmeng, mfisher, rmillner
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: stickshift-abstract-0.11.6-1+ Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-08 17:59:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Test resulting showing git failure none

Description Jhon Honce 2012-05-31 04:13:27 UTC
Created attachment 587934 [details]
Test resulting showing git failure

Description of problem:
`rhc-app snapshot restore...` fails when restoring a git repo with sub modules.

Version-Release number of selected component (if applicable):
Sprint#12

How reproducible:


Steps to Reproduce:
1. Run cucumber tests
2.
3.
  
Actual results:
/usr/bin/rhc-app snapshot restore -l cucumber-test+ci38279715 -a test -f '/tmp/test-ci38279715new.tar.gz' -p xyz123 -
:
.
Initialized empty Git repository in /var/lib/stickshift/cd3556c9cf184ad498b192c437db0e37/php-5.3/tmp/submodules/.git/ /usr/libexec/stickshift/cartridges/abstract/info/bin/deploy_git_dir.sh: line 30: cd: /var/lib/stickshift/cd3556c9cf184ad498b192c437db0e37/test//tmp/submodules

Expected results:
Restore would rebuild git repo including submodules

Additional info:

Log containing error: https://ci.dev.openshift.redhat.com/jenkins/view/old%20school/job/libra_check/lastSuccessfulBuild/artifact/rhc/log/cucumber.log

Comment 1 Jhon Honce 2012-05-31 04:16:13 UTC
Log also attached in case it gets removed from server.

Comment 2 John Poelstra 2012-05-31 17:29:29 UTC
should be fixed today

Comment 3 Rob Millner 2012-06-01 00:48:01 UTC
Crankcase pull request 98.

Comment 4 Meng Bo 2012-06-01 09:44:51 UTC
verified on devenv_1812

_________

Restoring from snapshot app1.tar.gz...

Stopping application...
Waiting for stop to finish
Done
Removing old git repo: ~/git/app1.git/
Removing old data dir: ~/app1/app-root/data/*
Restoring ~/git/app1.git and ~/app-root/data
~/git/app1.git ~
~/app1/tmp ~/git/app1.git ~
Initialized empty Git repository in /var/lib/stickshift/211f9326a95f427886d834081071befd/php-5.3/tmp/submodules/.git/
Submodule 'wolfcms-example' (https://github.com/openshift/wolfcms-example.git) registered for path 'wolfcms-example'
Initialized empty Git repository in /var/lib/stickshift/211f9326a95f427886d834081071befd/php-5.3/tmp/submodules/wolfcms-example/.git/
Submodule path 'wolfcms-example': checked out '8acdb01176ea8ef98f9b790c541dc5a6f41052ca'
Entering 'wolfcms-example'
~/git/app1.git ~
~
Running .openshift/action_hooks/pre_build
Running .openshift/action_hooks/build
Running .openshift/action_hooks/deploy
Starting application...
Done
Running .openshift/action_hooks/post_deploy
Terminating...