Bug 827125

Summary: double-close bugs in libvirt
Product: [Fedora] Fedora Reporter: Eric Blake <eblake>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 17CC: acathrow, ajia, berrange, clalancette, crobinso, dallan, dougsland, dyasny, dyuan, eblake, gsun, itamar, jforbes, juzhang, jwest, jyang, laine, libvirt-maint, linuxdev-bm, linuxdev-kernel-it, lsoft-lapl-pj, ltroan, mfuruta, michen, myamazak, mzhan, plyons, rwu, tmuneda, veillard, virt-maint, weizhan
Target Milestone: ---Keywords: OtherQA, ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: QJ120411-023
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 823716
: 827127 (view as bug list) Environment:
Last Closed: 2012-07-04 12:48:46 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 823716    
Bug Blocks: 827127    

Comment 1 Eric Blake 2012-05-31 13:00:06 EDT
We need six consecutive commits backported to F17, as this set of double-close bugs can cause rather insidious failures of libvirt.

b19c236d69278c967d2d8b4aae97ac76213f1c10 qemu: avoid closing fd more than once
746ff701e8727439cac8ca72531d82e5cb7fa129 command: check for fork error before closing fd
f3cfc7c8848006b613e09bb1acd081716854527e fdstream: avoid double close bug
da831afcf2f6c0d3ed1ea3128a6208f548a05d8f command: avoid double close bugs
655cffa0f25be40c68624036af80bde102177612 avoid fd leak
0a045f01cfa48fabd41c801e3f44034a4e6da485 avoid closing uninitialized fd
Comment 2 Cole Robinson 2012-07-04 12:48:46 EDT
Fixed in current release