Bug 827466

Summary: chronyd service shows wrong startup status
Product: [Fedora] Fedora EPEL Reporter: Ludwin Janvier <lud.janvier>
Component: chronyAssignee: Miroslav Lichvar <mlichvar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: el6CC: mlichvar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: chrony-1.25-4.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-28 21:08:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch none

Description Ludwin Janvier 2012-06-01 14:34:20 UTC
Created attachment 588482 [details]
patch

Description of problem:
When starting with a good configuration, chronyd shows a failure notice:
Adding dhclient NTP servers to chrony:                     [FAILED]

Whereas both my ntp server in /etc/chrony.conf and in my dhcp lease, service startup is OK:
Adding dhclient NTP servers to chrony:                     [  OK  ]

Version-Release number of selected component (if applicable):
Name        : chrony
Arch        : x86_64
Version     : 1.25
Release     : 2.el6

How reproducible:
Always

Steps to Reproduce:
1. service chronyd start
2.
3.
  
Actual results:
FAILED

Expected results:
OK

Additional info:
The bug is in /etc/init.d/chronyd, line 51
the chrony_command function returns true when grep match an error, and false when there's no error.
My patch is to remove this grep.

Comment 1 Miroslav Lichvar 2014-01-10 16:17:48 UTC
I've changed the chronyc wrapper to return with the chronyc exit code instead of grep. Thanks for the report.

Comment 2 Fedora Update System 2014-01-10 16:24:30 UTC
chrony-1.25-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/chrony-1.25-4.el6

Comment 3 Fedora Update System 2014-01-10 23:41:42 UTC
Package chrony-1.25-4.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing chrony-1.25-4.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-0119/chrony-1.25-4.el6
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-01-28 21:08:22 UTC
chrony-1.25-4.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.