Bug 827547
| Summary: | [eap6] WAR Deployment fails for manually imported standalone server | |||
|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Libor Zoubek <lzoubek> | |
| Component: | Plugins | Assignee: | Lukas Krejci <lkrejci> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | urgent | |||
| Version: | 4.4 | CC: | hrupp, lkrejci, snegrea, theute | |
| Target Milestone: | --- | |||
| Target Release: | JON 3.1.1 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 832086 832090 (view as bug list) | Environment: | ||
| Last Closed: | 2013-09-03 15:06:11 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 707223, 782579, 832086, 832090 | |||
|
Description
Libor Zoubek
2012-06-01 18:11:06 UTC
ContentSourceManager.outputPackageBitsForChildResource() in the server NPEs:
public long outputPackageBitsForChildResource(int parentResourceId, String resourceTypeName,
PackageDetailsKey packageDetailsKey, OutputStream outputStream) {
Resource parentResource = entityManager.find(Resource.class, parentResourceId);
ResourceType parentResourceType = parentResource.getResourceType();
the parentResourceId is 0 and thus no parentResource found, which then leads to the NPE in the last line shown.
Above invocation is triggered in the as7 plugin by
org.rhq.modules.plugins.jbossas7.BaseComponent#deployContent
contentServices.downloadPackageBitsForChildResource(cctx, resourceTypeName, details.getKey(), out);
Which calls org.rhq.core.pc.content.ContentManager#downloadPackageBitsForChildResource
which then calls the server with a parentResource id of contentContext.resourceId which is 0
The content context is passed into the ResourceComponent at start() time and it looks like this may be too early for manually added resources, as the logs
say
2012-06-04 14:15:38,470 INFO [WorkerThread#0[172.31.7.7:65242]] (rhq.core.pc.inventory.InventoryManager)- Resource ID is 0! Content feat
ures will not work until the resource is synced with server
Addition: that code path above works for auto-discovered AS7 instances for over a year now. This issue will very probably affect all manually imported resources. For the concrete As7 case: - people can put an agent on the machine and use autodiscovery where this issues does not appear - they can still use manual add for config + monitoring - the fix most likely is not trivial So no target for 3.1 Key questions Does this affect other resource types? e.g. jbas5 in jon310 Did this issue exist in previous versions of JON? e.g. jbas5 in jon301 >Does this affect other resource types? Yes. I tested with a master build and EAP 5.1.1. The exact same behaviour was observed. This is not related to a specific plugin; this is a plugin container problem. From the logs, I can see that the manually imported resource does not have the resourceid updated correctly after creation. >Did this issue exist in previous versions of JON? Yes. Exact same behaviour was observed with JON 3.0.1 and EAP 5.1.1. So from Stefan's analysis this isn't a regression and isn't restricted to as7 resources. Keeping this as Urgent and targeting JON3.1.1 Bug 832090 fixed this in master... release/jon3.1.x branch commits: http://git.fedorahosted.org/git?p=rhq/rhq.git;a=commit;h=5a4b2ec79c9f05a13f24d253aea91227df7fd40f http://git.fedorahosted.org/git?p=rhq/rhq.git;a=commit;h=bf517b9d9a0f31ae370e7c8b952c45083d054866 JON 3.1.1 ER1 build is available. Moving to ON_QA. https://brewweb.devel.redhat.com/buildinfo?buildID=226942 verified on JON 3.1.1 ER1 Bulk closing of old issues in VERIFIED state. |