Bug 827633
Summary: | Unable to enter a Drift Detection Definition Base Directory fileSystem path that contains parenthesis | |||
---|---|---|---|---|
Product: | [JBoss] JBoss Operations Network | Reporter: | Larry O'Leary <loleary> | |
Component: | Drift, UI | Assignee: | Jay Shaughnessy <jshaughn> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | |
Severity: | high | Docs Contact: | ||
Priority: | urgent | |||
Version: | JON 3.1.0 | CC: | jshaughn, skondkar | |
Target Milestone: | --- | |||
Target Release: | JON 3.1.1 | |||
Hardware: | All | |||
OS: | All | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 827634 (view as bug list) | Environment: |
JON 3.0.1 and JON 3.1.0.Beta1
Tested in Linux
|
|
Last Closed: | 2013-09-11 11:02:23 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 827634 | |||
Bug Blocks: |
Description
Larry O'Leary
2012-06-01 22:25:40 UTC
Fixed in upstream, waiting for branch to cherry-pick. Release/jon3.1.x commit: 081742ba378fd3d8d0e9e3942faed49210fedd9d - Add support for Windows allowance of parentheses in directory names. - Add support for more flexible specification of the drift base directory in a Drift Filter. - Add relevant tests for new features. Cherry-pick of master db072ef663ee9d9e276971e1cce9021e26cafef5 A second commit for this one as well: Release/jon3.1.x commit: b0e59ada3a18169b3a1a6802ec4c9516364090f9 There were two ways to go here. One was to add special case handling for the various filter paths that equate to ".". The other was to normalize in the Filter constructor. Since I tried option 1 and missed a spot in my first try to fix it, I've now opted for option 2. The downside is only that what the user types may get normalized to ".". But I added some more description text to state as much. Also, existing Filter paths using "/" or "./" will need to be updated to "." manually, but I doubt there are any out there currently since it wasn't working. Conflicts: modules/core/plugin-container/src/main/java/org/rhq/core/pc/drift/DriftDetector.java modules/core/plugin-container/src/test/java/org/rhq/core/pc/drift/FilterFileVisitorTest.java Cherry-pick of master commit: 00ea14c228bd08d6572d0f17ef8040e447b9a0dd Note, these cherry picked commits also fix bug 827647 - Relative path for Drift Detections Definition Include/Excludes Path does not handle relative path alias or trailing file separator correctly. The work was done together so even though 827647 was not triaged for 3.1.1 it was easier to take the fixes for both. JON 3.1.1 ER1 build is available. Moving to ON_QA. https://brewweb.devel.redhat.com/buildinfo?buildID=226942 Verified on Version: 3.1.1.ER3 (Build Number: 37108ca:67c6de8) Verified by following the steps. The Drift Detection Definition with Base Directory filesystem path containing a parenthesis is saved and a snapshot is created. |