Bug 827761
| Summary: | Review Request: vdr-skinenigmang - A skin for VDR based on the Enigma text2skin add on | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | MartinKG <mgansser> |
| Component: | Package Review | Assignee: | Ville Skyttä <ville.skytta> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 17 | CC: | mario.blaettermann, notting, package-review, ville.skytta |
| Target Milestone: | --- | Flags: | ville.skytta:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-19 16:58:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
MartinKG
2012-06-02 21:18:24 UTC
SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skinenigmang-0.1.2-3.fc17.src.rpm?a=ImpwhNg4EIg Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skinenigmang.spec?a=8ctTJcw1-qo changelog: * Tue Jun 12 2012 Martin Gansser <linux4martin> - 0.1.2-3 - added config patch - added flag and icons in file section - spec file cleanup > install -pm 644 %{SOURCE1} skinenigmang/flags
This copies the skinenigmang-logos-xpm-hi-20070702.tgz tarball to skinenigmang/flags, and it ends up in the binary package. Why is that?
Other than that, looks pretty good to me on a quick look.
(In reply to comment #2) > > install -pm 644 %{SOURCE1} skinenigmang/flags > > This copies the skinenigmang-logos-xpm-hi-20070702.tgz tarball to > skinenigmang/flags, and it ends up in the binary package. Why is that? It's unusual to call install in the %prep section. The Source1 should be unpacked only. This way, the binary package contains the xpm files only, not the tarball itself. thanks Mario, fixed in new rpm package. Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/0.1.2-4/vdr-skinenigmang.spec?a=eV_POBvkYYw SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/0.1.2-4/vdr-skinenigmang-0.1.2-4.fc17.src.rpm?a=c3c7_k3pkZI %changelog * Thu Jun 14 2012 Martin Gansser <linux4martin> - 0.1.2-4 - more spec file cleanups - fixed copying of source file to build dir URL is wrong, should probably be http://andreas.vdr-developer.org/enigmang/ License should probably be GPL+, I couldn't find anything in the tarball that'd say GPLv2+ (I've sent a patch for this upstream, so future versions may be GPLv2+). SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skinenigmang-0.1.2-5/vdr-skinenigmang-0.1.2-5.fc17.src.rpm?a=FrLMjrmUnt8 Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/vdr-skinenigmang/vdr-skinenigmang-0.1.2-5/vdr-skinenigmang.spec?a=NUOvlY-IKY8 %changelog * Sun Jun 16 2012 Martin Gansser <linux4martin> - 0.1.2-5 - fixed wrong url - changed license type from GPLv2+ to GPL+ The only thing I'm slightly wondering about is whether the theme files should have %{vdr_user}:root ownership instead of root:root - that's how other skins package them.
Anyway, I'll leave that up to you to decide before the first build, approved.
New Package SCM Request ======================= Package Name: vdr-skinenigmang Short Description: a skin for VDR based on the Enigma text2skin add on. Owners: martinkg Branches: f16 f17 f18 InitialCC: Git done (by process-git-requests). Don't request f18 yet, it's still devel. the package built successfully on koji vdr-skinenigmang-0.1.2-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/vdr-skinenigmang-0.1.2-5.fc17 vdr-skinenigmang-0.1.2-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/vdr-skinenigmang-0.1.2-5.fc16 vdr-skinenigmang-0.1.2-5.fc17 has been pushed to the Fedora 17 stable repository. vdr-skinenigmang-0.1.2-5.fc16 has been pushed to the Fedora 16 stable repository. vdr-skinenigmang-0.1.2-11.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/vdr-skinenigmang-0.1.2-11.fc18 vdr-skinenigmang-0.1.2-11.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |