Bug 827890

Summary: ovirt-engine-backend: rollback on snapshot preview failure did not change the snapshot state in db and image is presented as previewed
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Haim <hateya>
Severity: urgent Docs Contact:
Priority: high    
Version: 3.1.0CC: abaron, amureini, dyasny, hateya, iheim, lpeer, Rhev-m-bugs, yeylon, ykaul, yzaslavs
Target Milestone: ---   
Target Release: 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 19:58:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screen shots
none
logs none

Description Dafna Ron 2012-06-03 13:49:54 UTC
Created attachment 588861 [details]
screen shots

Description of problem:

after failure in preview of snapshot the snapshot appears as previewed in webadmin. 
checking the db snapshot table the status of the image is still IN_PREVIEW

this requires a manual intervention in db since we cannot create any snapshots, commit and undo will fail (since vdsm has rolled back). 

Version-Release number of selected component (if applicable):

si4

How reproducible:

100%

Steps to Reproduce:
1. create 3 domains + vm with 3 disks on each domain
2. create a snapshot
3. put one domain in maintenance -> preview snaoshot
  
Actual results:

action will fail and eventually rollback
image will remain in webadmin as in preview 
db snapshot table shows that the image is in status IN_PREVIEW

Expected results:

we should change image status in db once we rollback

Additional info:logs + screen shot

Comment 1 Dafna Ron 2012-06-03 13:51:36 UTC
Created attachment 588868 [details]
logs

Comment 2 Tal Nisan 2012-06-20 09:00:00 UTC
Could not reproduce in si6, getting the following message:
"    Cannot preview Snapshot. The relevant Storage Domain is inaccessible.
    -Please handle Storage Domain issues and retry the operation."
Can you please recheck?

Comment 3 Tal Nisan 2012-06-20 10:52:01 UTC
Fixed on si6

Comment 4 Dafna Ron 2012-06-20 16:20:19 UTC
verified on si6