Bug 827928
| Summary: | /sbin/fancontrol: line 465: [: too many arguments | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Erik Logtenberg <erik> |
| Component: | lm_sensors | Assignee: | Jaromír Cápík <jcapik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 23 | CC: | aghoras, dhoward, hdegoede, jcapik, ovasik, rvokal |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | jcapik:
needinfo?
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lm_sensors-3.3.5-6.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-18 01:58:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
So... is any more information required? Is this the right place for this bug report? Hello Erik. I became the new package owner/maintainer few weeks ago and I'll try to look at the issue asap. Regards, Jaromir. Could you please attach your /etc/fancontrol configuration file? Thanks. BR, J. Sure, no problem. This file was auto-generated by the way, I didn't edit it. $ cat /etc/fancontrol # Configuration file generated by pwmconfig, changes will be lost INTERVAL=10 DEVPATH=hwmon0=devices/platform/coretemp.0 hwmon1=devices/platform/f71882fg.656 DEVNAME=hwmon0=coretemp hwmon1=f71889a FCTEMPS=hwmon1/device/pwm1=hwmon0/device/temp1_input FCFANS= hwmon1/device/pwm1= MINTEMP=hwmon1/device/pwm1=40 MAXTEMP=hwmon1/device/pwm1=60 MINSTART=hwmon1/device/pwm1=150 MINSTOP=hwmon1/device/pwm1=0 Hi Erik. Yes, that was my second question. I didn't ask in my previous comment, because I wanted to avoid an accidental file overwrite. Now ... could You please try to regenerate the config and check for differences? Thanks, J. Okay, I stopped fancontrol, ran pwmconfig, saved the new config file and restarted fancontrol again. I see no difference in the generated config file: $ cat /etc/fancontrol # Configuration file generated by pwmconfig, changes will be lost INTERVAL=10 DEVPATH=hwmon0=devices/platform/coretemp.0 hwmon1=devices/platform/f71882fg.656 DEVNAME=hwmon0=coretemp hwmon1=f71889a FCTEMPS=hwmon1/device/pwm1=hwmon0/device/temp1_input FCFANS=hwmon1/device/pwm1= MINTEMP=hwmon1/device/pwm1=40 MAXTEMP=hwmon1/device/pwm1=60 MINSTART=hwmon1/device/pwm1=150 MINSTOP=hwmon1/device/pwm1=0 Well, at least it's consistent ;) Would you like me to paste the console output of pwmconfig too? It's kind of lengthy... But just to be sure, pwmconfig did rewrite the config file, I checked the timestamp: -rw-r--r--. 1 root root 398 Oct 23 15:13 /etc/fancontrol This message is a reminder that Fedora 17 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 17. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '17'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 17's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 17 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 17's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug is still open. It hasn't been fixed, and I'm still seeing this. This message is a reminder that Fedora 18 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 18. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '18'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 18's end of life. Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 18 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 18's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Hello Erik. Sorry for no response to your latest comments. May I ask you to retest that in Fedora 20? Thank you, Jaromir. I'll retest soon. I only run fancontrol on one of my machines and that machine isn't running Fedora 20 yet. As soon as I've upgraded that machine I'll get back with the results. near line 437 around:
else
fanval=1 # set it to a non zero value, so the rest of the script still works
fi
add the line: min_fanval=1 to get:
else
fanval=1 # set it to a non zero value, so the rest of the script still works
min_fanval=1
fi
Lol well it took almost 3 years and 4 major releases, but this does fix the bug. It would be nice if this change could be incorporated in the fancontrol package. Thanks for the news, guys! Unfortunately I have no HW for testing the fancontrol on and therefore the troubleshooting is not easy. Anyway, the modification looks reasonable. I'm gonna ask my colleagues whether they could lend me their HW for a quick test so that I could feel more comfortable with committing the modification. I couldn't find a suitable HW, therefore committing as is. Guys, this has been redesigned in the upstream version 3.4.0. The 3.4.0 version is already in Rawhide. Could you please test the rawhide package and share results? The RPMs can be obtained here: http://koji.fedoraproject.org/koji/buildinfo?buildID=665239 Thanks in advance. lm_sensors-3.3.5-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/lm_sensors-3.3.5-6.fc21 lm_sensors-3.3.5-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/lm_sensors-3.3.5-6.fc22 This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 Package lm_sensors-3.3.5-6.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lm_sensors-3.3.5-6.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-11623/lm_sensors-3.3.5-6.fc22 then log in and leave karma (feedback). lm_sensors-3.3.5-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. lm_sensors-3.3.5-6.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Fancontrol gives me the following error over and over: /sbin/fancontrol: line 465: [: too many arguments Version-Release number of selected component (if applicable): $ rpm -qf /sbin/fancontrol lm_sensors-3.3.2-2.fc17.x86_64 How reproducible: Always Steps to Reproduce: 1. Start fancontrol 2. Observe given errors Actual results: Fancontrol seems to work okay even though it gives these errors. It doesn't crash and it still appears to manage the fanspeed. Expected results: Silent operation. Additional info: I checked line 465 and it's this: 463 # calculate the new value from temperature and settings 464 pwmval="(${tval}-${mint})*(${maxpwm}-${minso})/(${maxt}-${mint})+${minso}" 465 if [ $pwmpval -eq 0 -o $min_fanval -eq 0 ] I noticed $pwmval contains an integer, varying roughly between 50 and 250 in my case. The $min_fanval variable though, is empty. I suspect that's not meant to be and is the cause of this error. Why this variable is empty, I don't know.