Bug 828008

Summary: This package is completely unusable in Fedora 17
Product: [Fedora] Fedora Reporter: Roland Pallai <dap78>
Component: xchat-rubyAssignee: Conrad Meyer <cse.cem+redhatbugz>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 17CC: cse.cem+redhatbugz
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-06 00:14:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
A fix for the problem none

Description Roland Pallai 2012-06-04 01:05:07 UTC
Created attachment 588992 [details]
A fix for the problem

Description of problem:
The STR2CSTR() function has been removed in ruby-1.9.2, but xchat-ruby still depends on it.

Compiler warning on rebuild:
"xchat-ruby.c:395:3: warning: implicit declaration of function ‘STR2CSTR’ [-Wimplicit-function-declaration]"

Version-Release number of selected component (if applicable):
1.2-12

How reproducible: 100%

Steps to Reproduce:
1. just try to use the package
2.
3.
  
Actual results:
XChat drops an error in the main window:
"AutoLoad failed for: /usr/lib64/xchat/plugins/xchat-ruby.so
 /usr/lib64/xchat/plugins/xchat-ruby.so: undefined symbol: STR2CSTR"

Expected results:
.

Additional info:
A simple fix attached; it's broke ruby-1.8 compatility at the same time.

Comment 1 Conrad Meyer 2012-06-05 02:32:11 UTC
Building with patch for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4127663

Assuming that builds we'll pull to F-17, which looks to be the first version of Fedora with ruby-1.9.x.

Comment 2 Thomas Moschny 2012-06-05 09:01:47 UTC
Resetting component.

Comment 3 Roland Pallai 2012-06-05 16:19:26 UTC
Hi Conrad,

It builds in my current Rawhide.

Can you send the error messages (aka "build.log")? - Maybe I can figure out what's wrong.

Comment 4 Conrad Meyer 2012-06-05 16:46:01 UTC
Here's the log:
http://koji.fedoraproject.org/koji/getfile?taskID=4127665&name=build.log

Patch is just (slightly) bad; this line "+++ xchat-ruby-1.2-src/src/xchat-ruby.c.orig" shouldn't have ".orig".

New build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4129608

Comment 5 Conrad Meyer 2012-06-05 16:53:48 UTC
That passed; here's F-17:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4129646

Comment 6 Fedora Update System 2012-06-05 17:12:18 UTC
xchat-ruby-1.2-13.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/xchat-ruby-1.2-13.fc17

Comment 7 Roland Pallai 2012-06-05 22:39:38 UTC
Thanks for fixing the patch.

The new build works fine.

Comment 8 Conrad Meyer 2012-06-06 00:14:29 UTC
Cool, thanks for trying it out. I'll close this now as the update is on its way to F-17. Thanks.

Comment 9 Fedora Update System 2012-06-07 02:54:36 UTC
xchat-ruby-1.2-13.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.