Bug 829246

Summary: virsh detach-disk will be failed with special image name
Product: Red Hat Enterprise Linux 6 Reporter: Alex Jia <ajia>
Component: libvirtAssignee: Osier Yang <jyang>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.3CC: acathrow, dallan, dyasny, dyuan, gkong, lagarcia, mzhan, rwu, weizhan
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-0.9.13-3.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-21 07:16:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alex Jia 2012-06-06 10:09:26 UTC
Description of problem:
If using local.img or attch.img as a image name then hot-plug the disk into guest, it's okay, however, it will be failed if hot-unplug the disk from the guest. 

Other special image name also should meet the problem, but I'm not sure what they are, at present, 'local.img' and 'attch.img' also can reproduce the issue.

Version-Release number of selected component (if applicable):
# rpm -q libvirt qemu-kvm-rhev kernel
libvirt-0.9.10-21.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.293.el6.x86_64
kernel-2.6.32-220.el6.x86_64

How reproducible:
always(using 'local.img' or 'attch.img' as a image name)

Steps to Reproduce:
1. # qemu-img create /var/lib/libvirt/images/local.img 10M
Formatting '/var/lib/libvirt/images/local.img', fmt=raw size=10485760
2. # virsh start <domain>   such as domain is 'myVM'
3. # virsh attach-disk myVM /var/lib/libvirt/images/local.img vdb
4. # virsh detach-disk myVM  vdb

Actual results:
# virsh attach-disk myVM /var/lib/libvirt/images/local.img vdb
Disk attached successfully

# virsh detach-disk myVM  vdb
error: Failed to detach disk
error: (device_definition):7: Extra content at the end of the document
    </disk>�
-----------^



Expected results:
fix it.

Additional info:
It seems virsh/libvirt can't deal with some special key words image name when running virsh detach-disk.

Comment 2 Osier Yang 2012-06-18 06:36:09 UTC
Fixed by upstream commit e3843d7f. Move to POST.

Comment 4 Geyang Kong 2012-07-11 01:56:12 UTC
I can also reproduce this bug with cdrom and an ISO file with specific name.

Comment 6 weizhang 2012-07-25 03:50:21 UTC
Verify pass on
libvirt-0.9.13-3.el6.x86_64
qemu-kvm-0.12.1.2-2.298.el6.x86_64
kernel-2.6.32-289.el6.x86_64

Do test
# virsh attach-disk vr-rhel6u3-x86_64-kvm /var/lib/libvirt/images/local.img vdb
Disk attached successfully

# virsh detach-disk vr-rhel6u3-x86_64-kvm vdb
Disk detached successfully

# virsh attach-disk vr-rhel6u3-x86_64-kvm /var/lib/libvirt/images/attch.img vdb
Disk attached successfully

# virsh detach-disk vr-rhel6u3-x86_64-kvm vdb
Disk detached successfully

no problem

Also according to comment 4, do testing
# virsh change-media 2 hdc /var/lib/libvirt/migrate/RHEL6.2-20111117.0-Server-x86_64-DVD1.iso --insert
succeeded to complete action insert on media

# virsh change-media 2 hdc --eject
succeeded to complete action eject on media

no problem

Comment 7 errata-xmlrpc 2013-02-21 07:16:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html