Bug 829315
| Summary: | Review Request: libzapojit - GLib/GObject wrapper for the SkyDrive and Hotmail REST APIs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Debarshi Ray <debarshir> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mclasen, notting, package-review |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-08 16:33:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Debarshi Ray
2012-06-06 12:58:05 UTC
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4132328 rpmlint output: libzapojit.src: W: spelling-error Summary(en_US) GLib -> G Lib, Glib, Gib libzapojit.src: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Gib libzapojit.src: W: invalid-url URL: http://live.gnome.org/Zapojit HTTP Error 404: Not Found libzapojit.x86_64: W: spelling-error Summary(en_US) GLib -> G Lib, Glib, Gib libzapojit.x86_64: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Gib libzapojit.x86_64: W: invalid-url URL: http://live.gnome.org/Zapojit HTTP Error 404: Not Found libzapojit-debuginfo.x86_64: W: invalid-url URL: http://live.gnome.org/Zapojit HTTP Error 404: Not Found libzapojit-devel.x86_64: W: invalid-url URL: http://live.gnome.org/Zapojit HTTP Error 404: Not Found 4 packages and 0 specfiles checked; 0 errors, 8 warnings. Nothing critical here. You may want to create http://live.gnome.org/Zapojit at some point package name: ok
spec file name: ok
packaging guidelines: ok, harmless observations:
- the %defattr lines are not strictly necessary anymore
- Group: is not needed either
license: ok
license field: ok
license file: ok
spec file language: ok
spec file readable: ok
upstream sources: ok
buildable: ok
excludearch: ok
buildrequires: ok
locale handling: ok
ldconfig: ok
system libs: ok
relocatable: ok
directory ownership:
- should co-own %{_datadir}/gir-1.0 and %{_libdir}/girepository-1.0
duplicate files: ok
file permissions: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
static libs: ok
devel files: ok
devel deps: ok
libtool archives: ok
gui apps: ok
duplicate ownership: ok
utf-8 filenames: ok
Summary: fix directory ownership, everything else looks fine
(In reply to comment #2) > You may want to create http://live.gnome.org/Zapojit at some point Done. (In reply to comment #3) > packaging guidelines: ok, harmless observations: > - the %defattr lines are not strictly necessary anymore > - Group: is not needed either Done. > directory ownership: > - should co-own %{_datadir}/gir-1.0 and %{_libdir}/girepository-1.0 Done. Spec URL: http://rishi.fedorapeople.org/libzapojit.spec SRPM URL: http://rishi.fedorapeople.org/libzapojit-0.0.2-2.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4140435 Looks all good now. Approved New Package SCM Request ======================= Package Name: libzapojit Short Description: GLib/GObject wrapper for the SkyDrive and Hotmail REST APIs Owners: rishi Branches: InitialCC: Git done (by process-git-requests). Already done. |