Bug 829726

Summary:	Review Request: wmmon - Nice system monitor for WindowMaker
Product:	[Fedora] Fedora	Reporter:	Alexey I. Froloff <raorn>
Component:	Package Review	Assignee:	Andreas Bierfert <andreas.bierfert>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	andreas.bierfert, notting, package-review
Target Milestone:	---	Flags:	andreas.bierfert: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-14 21:04:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexey I. Froloff 2012-06-07 12:28:05 UTC

Spec URL: http://raorn.fedorapeople.org/packages/wmmon/wmmon.spec
SRPM URL: http://raorn.fedorapeople.org/packages/wmmon/wmmon-1.0-1.b2.g575778a6.fc17.src.rpm
Description:

Simple CPU/Mem/IO usage monitor for WindowMaker.

Fedora Account System Username: raorn

Comment 1 Andreas Bierfert 2012-06-10 08:39:43 UTC

Some minor tweaks:

Please change the release to

0.1.beta2.yyyymmddgit575778a6

and substitute the date you took the snapshot on for yyyymmdd (see http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release) so that beta3 will be > beta2 and final 1.0 release will be greater then all the old versions...

The rest looks good.

Comment 2 Alexey I. Froloff 2012-06-28 09:02:15 UTC

http://raorn.fedorapeople.org/packages/wmmon/wmmon-1.0-0.1.b2.20120606git575778a6.fc17.src.rpm

diff --git a/wmmon.spec b/wmmon.spec
index 9726a51..3c66198 100644
--- a/wmmon.spec
+++ b/wmmon.spec
@@ -1,9 +1,10 @@
+%define snapdate 20120606
 %define treeish    575778a6
 %define beta   b2
 
 Name:      wmmon
 Version:   1.0
-Release:   1%{?beta:.%{beta}}.g%{treeish}%{?dist}
+Release:   %{?beta:0.}1%{?beta:.%{beta}}.%{snapdate}git%{treeish}%{?dist}
 Summary:   Nice system monitor for WindowMaker
 
 Group:     User Interface/X
@@ -59,5 +60,5 @@ install -p -m644 dockapps/wmmon/wmmon.1 %{buildroot}%{_mandir}/man1/wmmon.1
 %{_mandir}/man1/wmmon.1*
 
 %changelog
-* Wed Jun 06 2012 Alexey I. Froloff <raorn> - 1.0-1.b2.g575778a6
+* Thu Jun 28 2012 Alexey I. Froloff <raorn> - 1.0-0.1.b2.20120606git575778a6
 - Initial build for Fedora


This looks terrible, however...

Comment 3 Andreas Bierfert 2012-06-28 14:02:19 UTC

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 * MUST rpmlint: ok, false positives on spelling.
 * package naming: ok
 * package guideline complience: ok
 * license: ok
 * license field: ok
 * spec language and legible: ok
 * source: ok, pulled from git. Documented in spec.
 * builds on f17 and rawhide koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=4204988
 * BR: ok
 * file permissions: ok
 * desktop file: not needed as this is a specialized dockapp
 * package runs on f17: ok
 * man page included: ok

package

2f9533456e0c5ecba55a499cc9e78bd90330ac1e70d9f72f55468fb96994126e  wmmon-1.0-0.1.b2.20120606git575778a6.fc17.src.rpm

approved
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAk/sY5UACgkQQEQyPsWM8cuhFACcC8YtkvFFV8Xx96ggHd+x9+1u
XHkAoJPn73OaFkGOpxFrXcSYk8/1Ouoo
=7dew
-----END PGP SIGNATURE-----

Please add me as CC on the SCM request.

Comment 4 Alexey I. Froloff 2012-06-28 14:15:51 UTC

New Package SCM Request
=======================
Package Name: wmmon
Short Description: Nice system monitor for WindowMaker
Owners: raorn
Branches: f17
InitialCC: awjb

Comment 5 Gwyn Ciesla 2012-06-28 14:34:25 UTC

Git done (by process-git-requests).