Bug 829794

Summary: Trying to access many top-level menu items as a user w/ no rights throws ISEs rather than permission denied.
Product: Red Hat Satellite Reporter: Corey Welton <cwelton>
Component: WebUIAssignee: Partha Aji <paji>
Status: CLOSED CURRENTRELEASE QA Contact: Corey Welton <cwelton>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.0.0CC: cpelland, dmacpher, mmccune, omaciel, ppokorny, snansi
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Access to pages without appropriate permissions resulted in a 500 Internal Server Error message. This fix allows users without permissions to only access systems but denies other pages with 403 Permission Denied.
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-10-24 14:22:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Corey Welton 2012-06-07 14:59:35 UTC
Description of problem:
When a user with no rights attempts to access certain menu items (i.e., perhaps by a bookmark) that said user does not have rights to, ISEs are thrown. User should be getting permission denied messages, or at very least, it should handle the situation gracefully.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.  Login as admin. Copy/bookmark the URL for any of the main top-level menu items -- Content Management, Systems, Organizations, etc.
2.  Create a user, "norights" which has no associated roles.
3.  Logout and log back in with user norights.
4.  Paste in your URL or visit bookmark, to try and access some of those pages.
  
Actual results:

500 Internal Server Error

Sorry about that! It seems something went wrong. If you continue having trouble with this, please contact an Administrator.

You might want to log out and log back in again to clear your cookies.
Error:

    undefined method `allowed_organizations' for nil:NilClass



Expected results:

Situation is handled gracefully - no ISEs.

Additional info:

Comment 2 Pavel Pokorny 2012-07-18 08:17:09 UTC
Katello 049d74c361:

As a user with no assigned roles I can access only systems. All other pages I tried (directly through URL) are 403 - Permission Denied.

So I think it is fixed. What page exactly was 500?

Comment 4 Corey Welton 2012-09-17 15:47:54 UTC
Maybe this got fixed with the UI redesign. It no longer occurs. User no longer gets ISEs.

CloudForms System Engine Version: 1.1.12-7.el6cf

Comment 5 Mike McCune 2012-10-24 14:22:04 UTC
closing, currentrelease since these seemingly got missed in the 1.0.1 errata