Bug 830053
Summary: | Review Request: ibus-libpinyin - Intelligent Pinyin engine based on libpinyin for IBus | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peng Wu <pwu> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | notting, package-review |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-07-23 02:45:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peng Wu
2012-06-08 05:36:37 UTC
Review: + koji build f18 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4147698 + rpmlint on rpms gave ibus-libpinyin.x86_64: E: incorrect-fsf-address /usr/share/ibus-libpinyin/setup/version.py ibus-libpinyin.x86_64: E: incorrect-fsf-address /usr/libexec/ibus-setup-libpinyin ibus-libpinyin.x86_64: E: incorrect-fsf-address /usr/share/ibus-libpinyin/setup/main2.py 2 packages and 0 specfiles checked; 3 errors, 0 warnings. ==> You can inform upstream to update fsf address + source verified with upstream as (sha1sum) 2fbc315711df1472cccd4849b3438d14faa65f94 ibus-libpinyin-1.4.0.tar.gz 2fbc315711df1472cccd4849b3438d14faa65f94 ../SOURCES/ibus-libpinyin-1.4.0.tar.gz + Package: ibus-libpinyin-1.4.0-1.fc18.x86_64 Provides: ibus-libpinyin = 1.4.0-1.fc18 ibus-libpinyin(x86-64) = 1.4.0-1.fc18 Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libibus-1.0.so.5()(64bit) liblua-5.1.so()(64bit) libm.so.6()(64bit) libopencc.so.1()(64bit) libpinyin.so.0()(64bit) libpinyin.so.0(LIBPINYIN)(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit) libuuid.so.1()(64bit) rtld(GNU_HASH) suggestions: 1) Try not to hardcode the version in requires and buildrequires. Only if there is strict dependency of any version then only mention that in spec. 2) If this package is not for RHEL then you can remove following a)removal of buildroot in %install b) %clean section c) %defattr(-,root,root,-) 3) A new macro has been introduced in latest changes in packaging guidelines. See http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used Use -> %make_install INSTALL="install -p" above will also preserve timestamps. APPROVED. New Package SCM Request ======================= Package Name: ibus-libpinyin Short Description: Intelligent Pinyin engine based on libpinyin for IBus Owners: pwu Branches: f16 f17 InitialCC: i18n-team petersen Git done (by process-git-requests). When can this be closed? Sorry, forget it. Close bug. |